From: Yong Zhang <yong.zhang0@gmail•com>
To: Thomas Gleixner <tglx@linutronix•de>
Cc: perex@perex•cz, dhowells@redhat•com, prakity@marvell•com,
netdev@vger•kernel.org, chunkeey@googlemail•com,
sonic.zhang@analog•com, klaus.kudielka@ieee•org,
t.sailer@alumni•ethz.ch, khilman@ti•com, eric.dumazet@gmail•com,
jhovold@gmail•com, cyril@ti•com, rmk+kernel@arm•linux.org.uk,
mingo@elte•hu, jpr@f6fbb•org, adobriyan@gmail•com,
jreuter@yaina•de, cbe-oss-dev@lists•ozlabs.org,
martinez.javier@gmail•com, samuel@sortiz•org, vapier@gentoo•org,
grundler@parisc-linux•org, tklauser@distanz•ch,
lucas.demarchi@profusion•mobi, u.kleine-koenig@pengutronix•de,
olof@lixom•net, uclinux-dist-devel@blackfin•uclinux.org,
linux-hams@vger•kernel.org, leitao@linux•vnet.ibm.com,
blogic@openwrt•org, shawn.guo@linaro•org, nico@fluxnic•net,
geoff@infradead•org, jkosina@suse•cz,
linux-wireless@vger•kernel.org, linux-kernel@vger•kernel.org,
ralf@linux-mips•org, ralph.hempel@lantiq•com, jdmas
Subject: Re: [PATCH 45/62] net: irq: Remove IRQF_DISABLED
Date: Thu, 8 Sep 2011 21:41:09 +0800 [thread overview]
Message-ID: <20110908134108.GC2310@zhy> (raw)
In-Reply-To: <alpine.LFD.2.02.1109072000290.2723@ionos>
On Wed, Sep 07, 2011 at 08:03:14PM +0200, Thomas Gleixner wrote:
> On Wed, 7 Sep 2011, David Miller wrote:
>
> > From: Thomas Gleixner <tglx@linutronix•de>
> > Date: Wed, 7 Sep 2011 19:32:39 +0200 (CEST)
> >
> > > On Wed, 7 Sep 2011, David Miller wrote:
> > >
> > >> From: Yong Zhang <yong.zhang0@gmail•com>
> > >> Date: Wed, 7 Sep 2011 16:10:42 +0800
> > >>
> > >> > This flag is a NOOP and can be removed now.
> > >> >
> > >> > Signed-off-by: Yong Zhang <yong.zhang0@gmail•com>
> > >>
> > >> I have the same concerns here as I had for the sparc case.
> > >>
> > >> Some of these drivers might be using IRQF_DISABLED to make sure the
> > >> IRQ cannot be delivered until it is explicitly enabled via an
> > >> enable_irq() call.
> > >>
> > >> How is that being accomodated now?
> > >
> > > Again IRQF_DISABLED never ever had that functionality.
> >
> > My bad.
> >
> > But what if these interrupts want interrupts disabled during their
> > interrupt handler, for other reasons?
>
> We run ALL interrupt handlers with irqs disabled always.
>
> > This has the potential to break tons of stuff, especially on the
> > really old chips which almost no developers have any more but some
> > user might try to use.
>
> It won't. We removed IRQF_DISABLED from kernel/irq/* long ago
Yeah, and this is why we say it's a NOOP now :)
Thanks,
Yong
prev parent reply other threads:[~2011-09-08 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1315383059-3673-1-git-send-email-yong.zhang0@gmail.com>
2011-09-07 8:10 ` [PATCH 39/62] ISDN: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-07 8:10 ` [PATCH 45/62] net: " Yong Zhang
2011-09-07 17:13 ` David Miller
2011-09-07 17:32 ` Thomas Gleixner
2011-09-07 17:52 ` David Miller
2011-09-07 18:03 ` Thomas Gleixner
2011-09-08 13:41 ` Yong Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908134108.GC2310@zhy \
--to=yong.zhang0@gmail$(echo .)com \
--cc=adobriyan@gmail$(echo .)com \
--cc=blogic@openwrt$(echo .)org \
--cc=cbe-oss-dev@lists$(echo .)ozlabs.org \
--cc=chunkeey@googlemail$(echo .)com \
--cc=cyril@ti$(echo .)com \
--cc=dhowells@redhat$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=geoff@infradead$(echo .)org \
--cc=grundler@parisc-linux$(echo .)org \
--cc=jhovold@gmail$(echo .)com \
--cc=jkosina@suse$(echo .)cz \
--cc=jpr@f6fbb$(echo .)org \
--cc=jreuter@yaina$(echo .)de \
--cc=khilman@ti$(echo .)com \
--cc=klaus.kudielka@ieee$(echo .)org \
--cc=leitao@linux$(echo .)vnet.ibm.com \
--cc=linux-hams@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=lucas.demarchi@profusion$(echo .)mobi \
--cc=martinez.javier@gmail$(echo .)com \
--cc=mingo@elte$(echo .)hu \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nico@fluxnic$(echo .)net \
--cc=olof@lixom$(echo .)net \
--cc=perex@perex$(echo .)cz \
--cc=prakity@marvell$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=ralph.hempel@lantiq$(echo .)com \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=samuel@sortiz$(echo .)org \
--cc=shawn.guo@linaro$(echo .)org \
--cc=sonic.zhang@analog$(echo .)com \
--cc=t.sailer@alumni$(echo .)ethz.ch \
--cc=tglx@linutronix$(echo .)de \
--cc=tklauser@distanz$(echo .)ch \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
--cc=vapier@gentoo$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox