From: Stephen Hemminger <shemminger@vyatta•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: "Rose, Gregory V" <gregory.v.rose@intel•com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"gospo@redhat•com" <gospo@redhat•com>
Subject: Re: [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check
Date: Mon, 26 Sep 2011 09:47:19 -0700 [thread overview]
Message-ID: <20110926094719.0cb6c296@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1317055319.2773.41.camel@bwh-desktop>
On Mon, 26 Sep 2011 17:41:59 +0100
Ben Hutchings <bhutchings@solarflare•com> wrote:
> On Mon, 2011-09-26 at 09:21 -0700, Rose, Gregory V wrote:
> > > -----Original Message-----
> > > From: Stephen Hemminger [mailto:shemminger@vyatta•com]
> > > Sent: Sunday, September 25, 2011 10:24 AM
> > > To: Kirsher, Jeffrey T
> > > Cc: Rose, Gregory V; davem@davemloft•net; netdev@vger•kernel.org;
> > > gospo@redhat•com
> > > Subject: Re: [net-next] iproute2: Add new command to IP link to
> > > enable/disable VF spoof check
> > >
> > > On Sun, 25 Sep 2011 01:23:18 -0700
> > > Jeff Kirsher <jeffrey.t.kirsher@intel•com> wrote:
> > >
> > > > From: Greg Rose <gregory.v.rose@intel•com>
> > > >
> > > > Add IP link command parsing for VF spoof checking enable/disable
> > > >
> > > > Signed-off-by: Greg Rose <gregory.v.rose@intel•com>
> > > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
> > >
> > > See my comments about ABI compatibility. Can't just grow size of
> > > structure.
> > > Need to have new version of iproute work with older kernels.
> >
> > In this case I have no idea how to proceed. I'll go back and stare at it some more.
>
> Where is this structure used on the wire? I just don't see it.
>
> If the modified iproute2 crashes on older kernels, that's presumably
> because it's not correctly handling the case where IFLA_VF_SPOOFCHK is
> missing. Nothing to do with the size of this structure.
The proposed code is fine because the vf_info is not used by any code
in iproute right now and I doubt that any other tools are using it either.
next prev parent reply other threads:[~2011-09-26 16:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 8:23 [net-next] iproute2: Add new command to IP link to enable/disable VF spoof check Jeff Kirsher
2011-09-25 17:23 ` Stephen Hemminger
2011-09-26 16:21 ` Rose, Gregory V
2011-09-26 16:41 ` Ben Hutchings
2011-09-26 16:47 ` Stephen Hemminger [this message]
2011-09-26 16:58 ` Rose, Gregory V
2011-09-26 20:54 ` Christian Benvenuti (benve)
2011-09-26 21:00 ` David Miller
2011-09-26 21:19 ` Stephen Hemminger
2011-09-26 21:27 ` David Miller
2011-11-17 23:39 ` Greg Rose
2011-11-18 0:40 ` Stephen Hemminger
2011-11-18 0:43 ` Greg Rose
2011-11-18 0:45 ` Stephen Hemminger
2011-11-18 17:06 ` Greg Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926094719.0cb6c296@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@redhat$(echo .)com \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox