From: Stephen Hemminger <shemminger@vyatta•com>
To: "David S. Miller" <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: [PATCH 1/2] bridge: leave carrier on for empty bridge
Date: Mon, 03 Oct 2011 21:14:45 -0700 [thread overview]
Message-ID: <20111004041509.191082289@vyatta.com> (raw)
In-Reply-To: 20111004041444.793960297@vyatta.com
[-- Attachment #1: br-carrier-default.patch --]
[-- Type: text/plain, Size: 1058 bytes --]
This resolves a regression seen by some users of bridging.
Some users use the bridge like a dummy device.
They expect to be able to put an IPv6 address on the device
with no ports attached. Although there are better ways of doing
this, there is no reason to not allow it.
Note: the bridge still will reflect the state of ports in the
bridge if there are any added.
Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
---
This fix needs to go to stable as well since it has
been reported as a regression.
--- a/net/bridge/br_device.c 2011-09-01 08:52:27.596631192 -0700
+++ b/net/bridge/br_device.c 2011-09-01 09:01:03.256611801 -0700
@@ -91,7 +91,6 @@ static int br_dev_open(struct net_device
{
struct net_bridge *br = netdev_priv(dev);
- netif_carrier_off(dev);
netdev_update_features(dev);
netif_start_queue(dev);
br_stp_enable_bridge(br);
@@ -108,8 +107,6 @@ static int br_dev_stop(struct net_device
{
struct net_bridge *br = netdev_priv(dev);
- netif_carrier_off(dev);
-
br_stp_disable_bridge(br);
br_multicast_stop(br);
next parent reply other threads:[~2011-10-04 4:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111004041444.793960297@vyatta.com>
2011-10-04 4:14 ` Stephen Hemminger [this message]
2011-10-06 19:28 ` [PATCH 1/2] bridge: leave carrier on for empty bridge David Miller
2011-10-04 4:14 ` [PATCH 2/2] bridge: allow forwarding some link local frames Stephen Hemminger
2011-10-04 19:11 ` Benjamin Poirier
2011-10-05 19:40 ` Ben Hutchings
2011-10-05 20:50 ` Stephen Hemminger
2011-10-06 19:28 ` David Miller
2011-10-17 14:35 ` Ed Swierk
2011-10-17 15:18 ` Stephen Hemminger
2011-10-17 20:53 ` Ross Brattain
2011-10-17 21:09 ` Ed Swierk
2011-10-17 23:07 ` Ross Brattain
2011-10-17 23:36 ` Ed Swierk
2011-10-18 0:00 ` John Fastabend
[not found] <20110902172220.830228928@vyatta.com>
2011-09-02 17:22 ` [PATCH 1/2] bridge: leave carrier on for empty bridge Stephen Hemminger
2011-09-02 21:39 ` Nicolas de Pesloüan
2011-09-02 22:11 ` Stephen Hemminger
2011-09-03 2:15 ` Ang Way Chuang
2011-09-03 6:30 ` Stephen Hemminger
2011-09-25 8:55 ` Marc Haber
2011-09-03 18:32 ` Nicolas de Pesloüan
2011-09-04 4:14 ` Stephen Hemminger
2011-09-04 7:35 ` Nicolas de Pesloüan
2011-09-04 16:36 ` Stephen Hemminger
2011-09-04 17:12 ` Krzysztof Olędzki
2011-09-05 4:51 ` Ang Way Chuang
2011-09-05 17:18 ` Nicolas de Pesloüan
2011-09-05 17:57 ` Stephen Hemminger
2011-09-05 19:02 ` Ang Way Chuang
2011-09-05 22:45 ` Stephen Hemminger
2011-09-06 6:52 ` Nicolas de Pesloüan
2011-09-25 9:16 ` Marc Haber
2011-09-25 20:10 ` Nicolas de Pesloüan
2011-09-25 9:05 ` Marc Haber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004041509.191082289@vyatta.com \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox