From: Florian Fainelli <florian@openwrt•org>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH 1/2 net-next] r6040: invoke phy_{start,stop} when appropriate
Date: Fri, 7 Oct 2011 14:13:51 +0200 [thread overview]
Message-ID: <201110071413.51328.florian@openwrt.org> (raw)
In-Reply-To: <1317983087.3207.1.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Friday 07 October 2011 12:24:47 Eric Dumazet wrote:
> Le vendredi 07 octobre 2011 à 11:36 +0200, Florian Fainelli a écrit :
> > Joe reported to me that right after a bring up of a r6040 interface
> > the ethtool output had no consistent output with respect to link duplex
> > and speed. Fix this by adding a missing phy_start call in r6040_up and
> > conversely a phy_stop call in r6040_down to properly initialize phy
> > states.
> >
> > Reported-by: Joe Chou <Joe.Chou@rdc•com.tw>
> > Signed-off-by: Florian Fainelli <florian@openwrt•org>
> > ---
> > diff --git a/drivers/net/ethernet/rdc/r6040.c
> > b/drivers/net/ethernet/rdc/r6040.c index 2bbadc0..a128c3d 100644
> > --- a/drivers/net/ethernet/rdc/r6040.c
> > +++ b/drivers/net/ethernet/rdc/r6040.c
> > @@ -470,6 +470,8 @@ static void r6040_down(struct net_device *dev)
> >
> > iowrite16(adrp[0], ioaddr + MID_0L);
> > iowrite16(adrp[1], ioaddr + MID_0M);
> > iowrite16(adrp[2], ioaddr + MID_0H);
> >
> > +
> > + phy_stop(lp->phydev);
> >
> > }
> >
> > static int r6040_close(struct net_device *dev)
> >
> > @@ -727,6 +729,8 @@ static int r6040_up(struct net_device *dev)
> >
> > /* Initialize all MAC registers */
> > r6040_init_mac_regs(dev);
> >
> > + phy_start(lp->phydev);
> > +
> >
> > return 0;
> >
> > }
>
> You dont need to submit your patches twice (net and net-next)
>
> If its a bug fix, base your patch against net tree
>
> If its a new feature, against net-next
Allright, thanks for the tip. I just thought that would make it easier for
David to get this applied (especially after the drivers reorganization).
--
Florian
next prev parent reply other threads:[~2011-10-07 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 9:36 [PATCH 1/2 net-next] r6040: invoke phy_{start,stop} when appropriate Florian Fainelli
2011-10-07 10:24 ` Eric Dumazet
2011-10-07 12:13 ` Florian Fainelli [this message]
2011-10-10 3:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110071413.51328.florian@openwrt.org \
--to=florian@openwrt$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox