From: Dan Carpenter <dan.carpenter@oracle•com>
To: john.r.fastabend@intel•com
Cc: e1000-devel@lists•sourceforge.net, netdev@vger•kernel.org
Subject: Re: ixgbe: fixup hard dependencies on supporting 8 traffic classes
Date: Wed, 12 Oct 2011 09:35:55 +0300 [thread overview]
Message-ID: <20111012063555.GA23359@elgon.mountain> (raw)
Hello John Fastabend,
This is a semi-automatic email about new static checker warnings.
The patch 32701dc2e616: "ixgbe: fixup hard dependencies on supporting
8 traffic classes" from Sep 27, 2011, leads to the following Smatch
complaint:
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +3366 ixgbe_configure_dcb()
error: we previously assumed 'adapter->ixgbe_ieee_ets' could be null (see line 3357)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
3356
3357 if (adapter->ixgbe_ieee_ets) {
^^^^^^^^^^^^^^^^^^^^^^^
Null check.
3358 struct ieee_ets *ets = adapter->ixgbe_ieee_ets;
3359 int max_frame = dev->mtu + ETH_HLEN + ETH_FCS_LEN;
3360
3361 ixgbe_dcb_hw_ets(&adapter->hw, ets, max_frame);
3362 }
3363
3364 if (adapter->ixgbe_ieee_pfc) {
3365 struct ieee_pfc *pfc = adapter->ixgbe_ieee_pfc;
3366 u8 *prio_tc = adapter->ixgbe_ieee_ets->prio_tc;
^^^^^^^^^^^^^^^^^^^^^^^^^
New dereference.
3367
3368 ixgbe_dcb_hw_pfc_config(&adapter->hw, pfc->pfc_en,
regards,
dan carpenter
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2d-oct
_______________________________________________
E1000-devel mailing list
E1000-devel@lists•sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next reply other threads:[~2011-10-12 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 6:35 Dan Carpenter [this message]
2011-10-12 6:58 ` ixgbe: fixup hard dependencies on supporting 8 traffic classes John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012063555.GA23359@elgon.mountain \
--to=dan.carpenter@oracle$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox