Subject: Re: [PATCH net-next v4 4/8] forcedeth: expose module parameters in /sys/module

From: Stephen Hemminger <[email-masked]>
Date: Tue, 15 Nov 2011 14:32:31 -0800

On Tue, 15 Nov 2011 11:25:37 -0800
David Decotigny <[email-masked]> wrote:

> +module_param(optimization_mode, int, S_IRUGO);
>  MODULE_PARM_DESC(optimization_mode, "In throughput mode (0), every tx & rx packet will generate an interrupt. In CPU mode (1), interrupts are controlled by a timer. In dynamic mode (2), the mode toggles between throughput and CPU mode based on network load.");

Probably the original developer (or marketing data sheet), thought this was some
unique feature of the hardware. But most devices have this already.

This driver should just implement proper control irq coalescing control via ethtool
and get rid of the silly module parameter.