public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr•zoreil.com>
To: Dave Jones <davej@redhat•com>
Cc: netdev@vger•kernel.org, kernel-team@fedoraproject•org,
	hayeswang@realtek•com
Subject: Re: 3.1.0 rtl8169_open oops.
Date: Thu, 17 Nov 2011 01:34:36 +0100	[thread overview]
Message-ID: <20111117003436.GA3097@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20111115223701.GA31118@redhat.com>

Dave Jones <davej@redhat•com> :
[...]
> (gdb) list *(rtl8169_open)+0x34e
> 0x4c0f is in rtl8169_open (drivers/net/r8169.c:1881).
> 1876		bool rc = false;
> 1877	
> 1878		if (fw->size < FW_OPCODE_SIZE)
> 1879			goto out;
> 1880	
> 1881		if (!fw_info->magic) {
> 1882			size_t i, size, start;
> 1883			u8 checksum = 0;
> 1884	
> 1885			if (fw->size < sizeof(*fw_info))

Give me 24h. I hope it is not as trivial as it seems :o(

Btw the firmware included in F16 is not up-to-date (see
http://marc.info/?l=linux-kernel&m=131295492507686&w=2). The driver should
not mind though.

-- 
Ueimor

  reply	other threads:[~2011-11-17  0:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 22:37 3.1.0 rtl8169_open oops Dave Jones
2011-11-17  0:34 ` Francois Romieu [this message]
2011-11-17  0:53   ` Dave Jones
2011-11-17 12:26     ` hayeswang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111117003436.GA3097@electric-eye.fr.zoreil.com \
    --to=romieu@fr$(echo .)zoreil.com \
    --cc=davej@redhat$(echo .)com \
    --cc=hayeswang@realtek$(echo .)com \
    --cc=kernel-team@fedoraproject$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox