Subject: Re: [PATCH] ipip, sit: copy parms.name after register_netdevice

From: Stephen Hemminger <[email-masked]>
Date: Wed, 7 Dec 2011 20:16:10 -0800

On Thu, 8 Dec 2011 11:35:15 +0800
Ted Feng <[email-masked]> wrote:

> From: Ted Feng <[email-masked]>
> Same fix as 731abb9cb2 for ipip and sit tunnel.
> Commit 1c5cae815d removed an explicit call to dev_alloc_name in
> ipip_tunnel_locate and ipip6_tunnel_locate, because register_netdevice
> will now create a valid name. However the tunnel keeps a copy of the
> name in the private parms structure.
> 
> This shows up if you do a simple tunnel add, followed by a tunnel show:
> 

Ok, but keeping a private copy is not a good idea, since tunnel
can be renamed.
  ip li set dev tun0 name tunnel-of-love