public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public•gmane.org>
To: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: Dave Taht <dave.taht-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
	David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
	linux-wireless
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
	Hagen Paul Pfeifer <hagen-GvnIQ6b/HdU@public•gmane.org>,
	bloat-devel
	<bloat-devel-JXvr2/1DY2fm6VMwtOF2vx4hnT+Y9+D1@public•gmane.org>,
	bloat <bloat-JXvr2/1DY2fm6VMwtOF2vx4hnT+Y9+D1@public•gmane.org>
Subject: Re: [PATCH net-next] sch_red: Adaptative RED AQM
Date: Thu, 8 Dec 2011 09:21:30 -0800	[thread overview]
Message-ID: <20111208092130.656c39ff@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1323360363.2521.30.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>

On Thu, 08 Dec 2011 17:06:03 +0100
Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org> wrote:

> Changes against our RED implementation are :
> 
> max_p is no longer a negative power of two (1/(2^Plog)), but a Q0.32
> fixed point number, to allow full range described in Adatative paper.
> 
> To deliver a random number, we now use a reciprocal divide (thats really
> a multiply), but this operation is done once per marked/droped packet
> when in RED_BETWEEN_TRESH window, so added cost (compared to previous
> AND operation) is near zero.
> 
> dump operation gives current max_p value in a new TCA_RED_MAX_P
> attribute.
> 
> Example on a 10Mbit link :
> 
> tc qdisc add dev $DEV parent 1:1 handle 10: est 1sec 8sec red \
>    limit 400000 min 30000 max 90000 avpkt 1000 \
>    burst 55 ecn adaptative bandwidth 10Mbit
> 
> # tc -s -d qdisc show dev eth3
> ...
> qdisc red 10: parent 1:1 limit 400000b min 30000b max 90000b ecn
> adaptative ewma 5 max_p=0.113335 Scell_log 15
>  Sent 50414282 bytes 34504 pkt (dropped 35, overlimits 1392 requeues 0) 
>  rate 9749Kbit 831pps backlog 72056b 16p requeues 0 
>   marked 1357 early 35 pdrop 0 other 0
> 
> 
> Signed-off-by: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>

Is this backward compatible for users that don't specify
an adaptive parameter.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-12-08 17:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05  9:05 Time in Queue, bufferbloat, and... our accidentally interplanetary network Dave Taht
2011-12-05 10:59 ` Eric Dumazet
2011-12-06  2:03   ` Adrian Chadd
     [not found]     ` <CAJ-VmomuA7u5=zRGMK2Jd3WG+HWTRTZNST4JDVWU9kUEcfE91Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-07  9:59       ` Dave Taht
2011-12-07 10:15   ` Hagen Paul Pfeifer
2011-12-07 10:19     ` Hagen Paul Pfeifer
2011-12-07 11:53     ` [Bloat] " Eric Dumazet
2011-12-08 16:06   ` [PATCH net-next] sch_red: Adaptative RED AQM Eric Dumazet
2011-12-08 17:21     ` Stephen Hemminger [this message]
2011-12-08 18:16       ` Eric Dumazet
2011-12-09 12:46         ` [PATCH net-next] sch_red: generalize accurate MAX_P support to RED/GRED/CHOKE Eric Dumazet
2011-12-09 18:46           ` David Miller
2011-12-09  0:55     ` [PATCH net-next] sch_red: Adaptative RED AQM David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111208092130.656c39ff@nehalam.linuxnetplumber.net \
    --to=shemminger-ztmgi6mnkb3qt0dzr+alfa@public$(echo .)gmane.org \
    --cc=bloat-JXvr2/1DY2fm6VMwtOF2vx4hnT+Y9+D1@public$(echo .)gmane.org \
    --cc=bloat-devel-JXvr2/1DY2fm6VMwtOF2vx4hnT+Y9+D1@public$(echo .)gmane.org \
    --cc=dave.taht-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
    --cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
    --cc=hagen-GvnIQ6b/HdU@public$(echo .)gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox