public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta•com>
To: Rajesh Borundia <rajesh.borundia@qlogic•com>
Cc: "starlight@binnacle•cx" <starlight@binnacle•cx>,
	Sony Chacko <sony.chacko@qlogic•com>,
	linux-kernel <linux-kernel@vger•kernel.org>,
	netdev <netdev@vger•kernel.org>
Subject: Re: kernel 3.1.1 message:  <IRQ> warn_alloc_failed
Date: Tue, 13 Dec 2011 10:41:52 -0800	[thread overview]
Message-ID: <20111213104152.14c01911@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <13A253B3F9BEFE43B93C09CF75F63CAA8162593365@MNEXMB1.qlogic.org>

On Tue, 13 Dec 2011 11:42:13 -0600
Rajesh Borundia <rajesh.borundia@qlogic•com> wrote:

> Hi All,
> 
> Sorry for late reply.
> 
> Stephan,
> Thanks for analyzing.
> 
> Yes, the netxen adapter does not support fragmented page memory.
> They are not harmful messages. At that instant of time it may fail allocating
> memory for some buffers in the ring but after enough memory is available
> it will try to allocate memory for unallocated buffers in ring.
> 
> Or the other option could be to turn LRO off.
> 
> Rajesh  
> 
> ________________________________________
> From: starlight@binnacle•cx [starlight@binnacle•cx]
> Sent: Friday, December 09, 2011 11:33 PM
> To: Stephen Hemminger; Sony Chacko; Rajesh Borundia
> Cc: linux-kernel; netdev
> Subject: Re: kernel 3.1.1 message:  <IRQ> warn_alloc_failed
> 
> At 09:50 AM 12/9/2011 -0800, Stephen Hemminger wrote:
> >On Thu, 08 Dec 2011 21:10:02 -0500 starlight@binnacle•cx wrote:
> >
> >You are seeing memory allocation failures because device
> >is allocating a 16K (order 2) size socket buffer. You are using
> >netxen device, and it looks like the problem.
> >
> >From reading the netxen driver source. The LRO buffers
> >in this device are very large (8060+skb overhead).
> >Until the driver is fixed to use fragmented page size memory,
> >I recommend turning off LRO.
> 
> Thank you for the analysis.  As an alternative
> would it make sense to double or quadruple
> 
>     /proc/sys/vm/min_free_kbytes
> 
> or perhaps do the same for
> 
>     /proc/slabinfo(size-16384)
> 

The driver should be changed to call allocation with __GFP_NOWARN.
Change dev_alloc_skb(size) to
  __dev_alloc_skb(size, GFP_ATOMIC|__GFP_NOWARN)

Or better yet, switch to using netdev_alloc variant like
  __netdev_alloc_skb_ip_align(dev, length, GFP_ATOMIC|__GFP_NOWARN)

  reply	other threads:[~2011-12-13 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09  2:10 kernel 3.1.1 message: <IRQ> warn_alloc_failed starlight
2011-12-09 17:50 ` Stephen Hemminger
     [not found]   ` <20111209095014.14a647cd@nehalam.linuxnetplumber.net >
2011-12-09 18:03     ` starlight
2011-12-13 17:42       ` Rajesh Borundia
2011-12-13 18:41         ` Stephen Hemminger [this message]
2011-12-13 19:09           ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111213104152.14c01911@nehalam.linuxnetplumber.net \
    --to=shemminger@vyatta$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=rajesh.borundia@qlogic$(echo .)com \
    --cc=sony.chacko@qlogic$(echo .)com \
    --cc=starlight@binnacle$(echo .)cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox