From: Stephen Hemminger <shemminger@vyatta•com>
To: Florian Zumbiehl <florz@florz•de>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH] skge: restore multicast rx filter on resume
Date: Wed, 28 Dec 2011 09:27:14 -0800 [thread overview]
Message-ID: <20111228092714.0a6d5f80@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20111228074143.GA8041@florz.florz.dyndns.org>
On Wed, 28 Dec 2011 08:41:43 +0100
Florian Zumbiehl <florz@florz•de> wrote:
> Hi,
>
> > > > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> > > > index f4be5c7..cd968e5 100644
> > > > --- a/drivers/net/skge.c
> > > > +++ b/drivers/net/skge.c
> > > > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
> > > > dev_close(dev);
> > > > goto out;
> > > > }
> > > > + skge_set_multicast(dev);
> > > > }
> > > > }
> > > > out:
> >
> > Right idea, but it needs to be done in a different spot to catch
> > all the other device restart cases like changing settings.
>
> Roughly like this maybe? (Successfully tested with an MTU change ...)
>
> Florian
>
> ---------------------------------------------------------------------------
> skge: restore rx multicast filter on resume
>
> Signed-off-by: Florian Zumbiehl <florz@florz•de>
>
> diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> index f4be5c7..8f985a8 100644
> --- a/drivers/net/skge.c
> +++ b/drivers/net/skge.c
> @@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
> spin_unlock_irq(&hw->hw_lock);
>
> napi_enable(&skge->napi);
> +
> + skge_set_multicast(dev);
> +
> return 0;
>
> free_rx_ring:
Looks good. That is (basically) the same as the patch I was testing.
Acked-by: Stephen Hemminger <shemminger@vyatta•com>
next prev parent reply other threads:[~2011-12-28 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-25 8:18 [PATCH] skge: restore multicast rx filter on resume Florian Zumbiehl
2011-12-26 20:17 ` David Miller
2011-12-27 17:56 ` Stephen Hemminger
2011-12-28 7:41 ` Florian Zumbiehl
2011-12-28 17:27 ` Stephen Hemminger [this message]
2011-12-28 18:09 ` David Miller
2011-12-29 6:48 ` Florian Zumbiehl
2011-12-29 7:56 ` David Miller
2011-12-29 16:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228092714.0a6d5f80@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=florz@florz$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox