Subject: Re: linux-next: Tree for Dec 28 (nfnetlink)

From: Pablo Neira Ayuso <[email-masked]>
Date: Thu, 29 Dec 2011 02:03:30 +0100

On Wed, Dec 28, 2011 at 03:33:04PM -0500, David Miller wrote:
> From: Randy Dunlap <[email-masked]>
> Date: Wed, 28 Dec 2011 13:19:08 -0800
> 
> > On 12/28/2011 01:18 AM, Stephen Rothwell wrote:
> >> Hi all,
> >> 
> >> I got bored :-(  I also hate tree wide, flag day changes :-(
> >> 
> >> Changes since 20111222:
> > 
> > 
> > 
> > warning: (NETFILTER_XT_MATCH_NFACCT) selects NETFILTER_NETLINK_ACCT which has unmet direct dependencies (NET && INET && NETFILTER && NETFILTER_ADVANCED)
> > 
> > and then
> > 
> > ERROR: "nfnetlink_subsys_unregister" [net/netfilter/nfnetlink_acct.ko] undefined!
> > ERROR: "nfnetlink_subsys_register" [net/netfilter/nfnetlink_acct.ko] undefined!
> > 
> > 
> > Full randconfig file is attached.
> 
> Pablo please fix this, thanks.

Please, apply the following patch.
>>From 3e52c20b633f9c829eaa9fe693a0cbef10ac4d02 Mon Sep 17 00:00:00 2001
From: Pablo Neira Ayuso <[email-masked]>
Date: Thu, 29 Dec 2011 01:50:25 +0100
Subject: [PATCH] netfilter: Kconfig: fix unmet xt_nfacct dependencies

warning: (NETFILTER_XT_MATCH_NFACCT) selects NETFILTER_NETLINK_ACCT which has
nmet direct dependencies (NET && INET && NETFILTER && NETFILTER_ADVANCED)

and then

ERROR: "nfnetlink_subsys_unregister" [net/netfilter/nfnetlink_acct.ko]
ndefined!
ERROR: "nfnetlink_subsys_register" [net/netfilter/nfnetlink_acct.ko]
+undefined!

Reported-by: Randy Dunlap <[email-masked]>
Signed-off-by: Pablo Neira Ayuso <[email-masked]>
---
 net/netfilter/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index f6275a0..f8ac4ef 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -908,7 +908,7 @@ config NETFILTER_XT_MATCH_MULTIPORT
 
 config NETFILTER_XT_MATCH_NFACCT
 	tristate '"nfacct" match support'
-	default m if NETFILTER_ADVANCED=n
+	depends on NETFILTER_ADVANCED
 	select NETFILTER_NETLINK_ACCT
 	help
 	  This option allows you to use the extended accounting through
-- 
1.7.7.3