From: Konrad Rzeszutek Wilk <konrad.wilk@oracle•com>
To: Ian Campbell <Ian.Campbell@citrix•com>
Cc: Ben Hutchings <bhutchings@solarflare•com>,
Jan Beulich <JBeulich@suse•com>,
Konrad Rzeszutek Wilk <konrad@darnok•org>,
"davem@davemloft•net" <davem@davemloft•net>,
"dmitry.torokhov@gmail•com" <dmitry.torokhov@gmail•com>,
"FlorianSchandinat@gmx•de" <FlorianSchandinat@gmx•de>,
Jeremy Fitzhardinge <jeremy@goop•org>,
Jens Axboe <axboe@kernel•dk>,
"xen-devel@lists•xensource.com" <xen-devel@lists•xensource.com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH, v2] Xen: consolidate and simplify struct xenbus_driver instantiation
Date: Tue, 3 Jan 2012 15:36:38 -0500 [thread overview]
Message-ID: <20120103203637.GF17472@phenom.dumpdata.com> (raw)
In-Reply-To: <1324586301.13113.3.camel@dagon.hellion.org.uk>
On Thu, Dec 22, 2011 at 08:38:21PM +0000, Ian Campbell wrote:
> On Thu, 2011-12-22 at 14:44 +0000, Ben Hutchings wrote:
> > On Thu, 2011-12-22 at 11:57 +0000, Ian Campbell wrote:
> > > On Thu, 2011-12-22 at 11:51 +0000, Jan Beulich wrote:
> > > > >>> On 22.12.11 at 10:57, Ian Campbell <Ian.Campbell@citrix•com> wrote:
> > > > > On Thu, 2011-12-22 at 09:08 +0000, Jan Beulich wrote:
> > > > >> The 'name', 'owner', and 'mod_name' members are redundant with the
> > > > >> identically named fields in the 'driver' sub-structure. Rather than
> > > > >> switching each instance to specify these fields explicitly, introduce
> > > > >> a macro to simplify this.
> > > > >>
> > > > >> Eliminate further redundancy by allowing the drvname argument to
> > > > >> DEFINE_XENBUS_DRIVER() to be blank (in which case the first entry from
> > > > >> the ID table will be used for .driver.name).
> > > > >
> > > > > Any reason not to always use DRV_NAME here (which is generally a bit
> > > > > more specific e.g. "xen-foofront" rather than "foo") and rely on the id
> > > > > table for the shorter names used in xenstore?
> > > >
> > > > That would imply that DRV_NAME is always defined, but I don't
> > > > see this being the case.
> > >
> > > My mistake, I thought it was a Kbuild thing.
> >
> > You're maybe thinking of KBUILD_MODNAME.
>
> Yes, I think I was.
Ian, are you OK with this patch? I think Jan needs to repost once more with the
"pciback" -> DRV_NAME change and then it is OK?
I've tested it with all backends, except the pciback one, and I see no regressions
with 'xl' or 'xm' toolstack.
next prev parent reply other threads:[~2012-01-03 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 9:08 [PATCH, v2] Xen: consolidate and simplify struct xenbus_driver instantiation Jan Beulich
2011-12-22 9:57 ` Ian Campbell
2011-12-22 11:51 ` Jan Beulich
2011-12-22 11:57 ` Ian Campbell
2011-12-22 14:44 ` Ben Hutchings
2011-12-22 20:38 ` Ian Campbell
2012-01-03 20:36 ` Konrad Rzeszutek Wilk [this message]
2012-01-04 9:17 ` Jan Beulich
2012-01-04 9:20 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103203637.GF17472@phenom.dumpdata.com \
--to=konrad.wilk@oracle$(echo .)com \
--cc=FlorianSchandinat@gmx$(echo .)de \
--cc=Ian.Campbell@citrix$(echo .)com \
--cc=JBeulich@suse$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=jeremy@goop$(echo .)org \
--cc=konrad@darnok$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xen-devel@lists$(echo .)xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox