From: Stephen Hemminger <shemminger@vyatta•com>
To: Ian Campbell <ian.campbell@citrix•com>
Cc: xen-devel@lists•xensource.com, netdev@vger•kernel.org
Subject: [PATCH] xen-netback: make ops structs const
Date: Wed, 4 Jan 2012 13:56:58 -0800 [thread overview]
Message-ID: <20120104135658.0347211f@nehalam.linuxnetplumber.net> (raw)
All tables of function pointers should be const to make hacks
more difficult. Compile tested only.
Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
---
Patch against net-next
--- a/drivers/net/xen-netback/interface.c 2011-12-07 10:54:19.232282492 -0800
+++ b/drivers/net/xen-netback/interface.c 2012-01-04 13:16:04.414052721 -0800
@@ -223,7 +223,7 @@ static void xenvif_get_strings(struct ne
}
}
-static struct ethtool_ops xenvif_ethtool_ops = {
+static const struct ethtool_ops xenvif_ethtool_ops = {
.get_link = ethtool_op_get_link,
.get_sset_count = xenvif_get_sset_count,
@@ -231,7 +231,7 @@ static struct ethtool_ops xenvif_ethtool
.get_strings = xenvif_get_strings,
};
-static struct net_device_ops xenvif_netdev_ops = {
+static const struct net_device_ops xenvif_netdev_ops = {
.ndo_start_xmit = xenvif_start_xmit,
.ndo_get_stats = xenvif_get_stats,
.ndo_open = xenvif_open,
next reply other threads:[~2012-01-04 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 21:56 Stephen Hemminger [this message]
2012-01-05 8:44 ` [PATCH] xen-netback: make ops structs const Ian Campbell
2012-01-05 18:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104135658.0347211f@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=ian.campbell@citrix$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xen-devel@lists$(echo .)xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox