From: Stephen Hemminger <shemminger@vyatta•com>
To: Alan Cox <alan@linux•intel.com>
Cc: kvm@vger•kernel.org, "Michael S. Tsirkin" <mst@redhat•com>,
netdev@vger•kernel.org, kay.sievers@vrfy•org,
virtualization@lists•linux-foundation.org, device@lanana•org,
David Miller <davem@davemloft•net>
Subject: Re: [PATCH] vhost-net: add module alias (v2.1)
Date: Mon, 16 Jan 2012 07:52:36 -0800 [thread overview]
Message-ID: <20120116075236.110cc4b4@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20120116122645.2257b40b@bob.linux.org.uk>
On Mon, 16 Jan 2012 12:26:45 +0000
Alan Cox <alan@linux•intel.com> wrote:
> > > ACKs, NACKs? What is happening here?
> >
> > I would like an Ack from Alan Cox who switched vhost-net
> > to a dynamic minor in the first place, in commit
> > 79907d89c397b8bc2e05b347ec94e928ea919d33.
>
> Sorry device@lanana•org isn't yet back from the kernel hack incident.
>
> I don't read netdev so someone needs to summarise the issue and send me
> a copy of the patch to look at.
>
> Alan
Subject: vhost-net: add module alias (v2.1)
By adding some module aliases, programs (or users) won't have to explicitly
call modprobe. Vhost-net will always be available if built into the kernel.
It does require assigning a permanent minor number for depmod to work.
Also:
- use C99 style initialization.
- add missing entry in documentation for loop-control
Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
---
2.1 - add missing documentation for loop control as well
Documentation/devices.txt | 3 +++
drivers/vhost/net.c | 8 +++++---
include/linux/miscdevice.h | 1 +
3 files changed, 9 insertions(+), 3 deletions(-)
--- a/drivers/vhost/net.c 2012-01-12 14:14:25.681815487 -0800
+++ b/drivers/vhost/net.c 2012-01-12 18:09:56.810680816 -0800
@@ -856,9 +856,9 @@ static const struct file_operations vhos
};
static struct miscdevice vhost_net_misc = {
- MISC_DYNAMIC_MINOR,
- "vhost-net",
- &vhost_net_fops,
+ .minor = VHOST_NET_MINOR,
+ .name = "vhost-net",
+ .fops = &vhost_net_fops,
};
static int vhost_net_init(void)
@@ -879,3 +879,5 @@ MODULE_VERSION("0.0.1");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Michael S. Tsirkin");
MODULE_DESCRIPTION("Host kernel accelerator for virtio net");
+MODULE_ALIAS_MISCDEV(VHOST_NET_MINOR);
+MODULE_ALIAS("devname:vhost-net");
--- a/include/linux/miscdevice.h 2012-01-12 14:14:25.725815981 -0800
+++ b/include/linux/miscdevice.h 2012-01-12 18:09:56.810680816 -0800
@@ -42,6 +42,7 @@
#define AUTOFS_MINOR 235
#define MAPPER_CTRL_MINOR 236
#define LOOP_CTRL_MINOR 237
+#define VHOST_NET_MINOR 238
#define MISC_DYNAMIC_MINOR 255
struct device;
--- a/Documentation/devices.txt 2012-01-12 14:14:25.701815712 -0800
+++ b/Documentation/devices.txt 2012-01-12 18:09:56.814680860 -0800
@@ -447,6 +447,9 @@ Your cooperation is appreciated.
234 = /dev/btrfs-control Btrfs control device
235 = /dev/autofs Autofs control device
236 = /dev/mapper/control Device-Mapper control device
+ 237 = /dev/loop-control Loopback control device
+ 238 = /dev/vhost-net Host kernel accelerator for virtio net
+
240-254 Reserved for local use
255 Reserved for MISC_DYNAMIC_MINOR
next prev parent reply other threads:[~2012-01-16 15:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 4:54 [PATCH] vhost-net: add module alias Stephen Hemminger
2012-01-11 7:07 ` Michael Tokarev
2012-01-11 16:58 ` Stephen Hemminger
2012-01-11 17:02 ` Michael Tokarev
2012-01-11 17:03 ` Kay Sievers
2012-01-11 7:43 ` Amos Kong
2012-01-11 16:54 ` Stephen Hemminger
2012-01-11 18:15 ` Michael S. Tsirkin
2012-01-11 17:16 ` [PATCH] vhost-net: add module alias (v2) Stephen Hemminger
2012-01-11 18:09 ` Michael S. Tsirkin
2012-01-11 21:00 ` Ben Hutchings
2012-01-12 2:15 ` Zhi Yong Wu
2012-01-12 5:30 ` [PATCH] vhost-net: add module alias (v2.1) Stephen Hemminger
2012-01-13 4:07 ` David Miller
2012-01-13 4:19 ` Kay Sievers
2012-01-13 18:12 ` David Miller
2012-01-15 12:42 ` Michael S. Tsirkin
2012-01-16 12:26 ` Alan Cox
2012-01-16 15:52 ` Stephen Hemminger [this message]
2012-01-16 23:06 ` David Miller
2012-01-16 23:34 ` Alan Cox
2012-01-12 20:04 ` [PATCH] vhost-net: add module alias (v2) Thadeu Lima de Souza Cascardo
2012-01-16 12:28 ` [PATCH] vhost-net: add module alias Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116075236.110cc4b4@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=alan@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=device@lanana$(echo .)org \
--cc=kay.sievers@vrfy$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox