From: "J. Bruce Fields" <bfields@fieldses•org>
To: Stanislav Kinsbursky <skinsbursky@parallels•com>
Cc: Trond.Myklebust@netapp•com, linux-nfs@vger•kernel.org,
xemul@parallels•com, neilb@suse•de, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, jbottomley@parallels•com,
davem@davemloft•net, devel@openvz•org
Subject: Re: [PATCH 2/5] SUNRPC: create unix gid cache per network namespace
Date: Thu, 19 Jan 2012 11:24:31 -0500 [thread overview]
Message-ID: <20120119162431.GC527@fieldses.org> (raw)
In-Reply-To: <20120119144914.9957.73951.stgit@localhost6.localdomain6>
On Thu, Jan 19, 2012 at 06:49:14PM +0400, Stanislav Kinsbursky wrote:
> This patch makes unix_gid_cache cache detail allocated and registered per
> network namespace context.
> Thus with this patch unix_gid_cache contents for network namespace "X" are
> controlled from proc file system mount for the same network namespace "X".
I'm confused--this seems half-done. I see that you're creating the gid
caches dynamically, but there's still this static definition:
> struct cache_detail unix_gid_cache = {
> .owner = THIS_MODULE,
> .hash_size = GID_HASHMAX,
> - .hash_table = gid_table,
> .name = "auth.unix.gid",
> .cache_put = unix_gid_put,
> .cache_upcall = unix_gid_upcall,
And it looks like unix_gid_lookup is still using this static
unix_gid_cache. Maybe I'm missing something....
--b.
next prev parent reply other threads:[~2012-01-19 16:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 14:48 [PATCH 0/5] SUNRPC: make caches network namespace aware Stanislav Kinsbursky
2012-01-19 14:49 ` [PATCH 1/5] SUNRPC: cache creation and destruction routines introduced Stanislav Kinsbursky
2012-01-19 14:49 ` [PATCH 2/5] SUNRPC: create unix gid cache per network namespace Stanislav Kinsbursky
2012-01-19 16:24 ` J. Bruce Fields [this message]
2012-01-19 17:00 ` Stanislav Kinsbursky
2012-01-19 14:49 ` [PATCH 3/5] SUNRPC: create GSS auth " Stanislav Kinsbursky
[not found] ` <20120119144922.9957.39352.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-01-19 16:31 ` J. Bruce Fields
2012-01-19 17:04 ` Stanislav Kinsbursky
2012-01-19 17:40 ` J. Bruce Fields
2012-01-19 17:51 ` Stanislav Kinsbursky
2012-01-19 14:49 ` [PATCH 5/5] SUNRPC: generic cache register routines removed Stanislav Kinsbursky
[not found] ` <20120119144517.9957.59143.stgit-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org>
2012-01-19 14:49 ` [PATCH 4/5] SUNRPC: ip map cache per network namespace cleanup Stanislav Kinsbursky
2012-01-19 16:37 ` J. Bruce Fields
2012-01-19 17:10 ` Stanislav Kinsbursky
[not found] ` <4F184E70.5070902-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-01-19 22:21 ` J. Bruce Fields
2012-01-19 15:19 ` [PATCH 0/5] SUNRPC: make caches network namespace aware Trond Myklebust
2012-01-19 15:31 ` Stanislav Kinsbursky
2012-01-19 15:34 ` Myklebust, Trond
2012-01-19 15:43 ` Stanislav Kinsbursky
2012-01-19 15:47 ` bfields
2012-01-19 16:01 ` Stanislav Kinsbursky
2012-01-19 17:34 ` Myklebust, Trond
[not found] ` <1326986392.6114.1.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2012-01-19 22:40 ` J. Bruce Fields
2012-01-19 17:14 ` Stanislav Kinsbursky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119162431.GC527@fieldses.org \
--to=bfields@fieldses$(echo .)org \
--cc=Trond.Myklebust@netapp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@openvz$(echo .)org \
--cc=jbottomley@parallels$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=neilb@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=skinsbursky@parallels$(echo .)com \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox