From: "Matt Carlson" <mcarlson@broadcom•com>
To: "James Bottomley" <James.Bottomley@HansenPartnership•com>
Cc: "Rafael J. Wysocki" <rjw@sisk•pl>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Kernel Testers List" <kernel-testers@vger•kernel.org>,
"Maciej Rutecki" <maciej.rutecki@gmail•com>,
"Florian Mickler" <florian@mickler•org>,
"Matt Carlson" <mcarlson@broadcom•com>,
"Michael Chan" <mchan@broadcom•com>,
"Ben Hutchings" <bhutchings@solarflare•com>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1
Date: Mon, 27 Feb 2012 17:24:08 -0800 [thread overview]
Message-ID: <20120228012408.GA29622@mcarlson.broadcom.com> (raw)
In-Reply-To: <1330386274.2822.105.camel@dabdike.int.hansenpartnership.com>
On Mon, Feb 27, 2012 at 05:44:34PM -0600, James Bottomley wrote:
> On Thu, 2012-02-23 at 23:55 +0100, Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a summary report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 3.2. Please verify if it still should be listed and let the tracking team
> > know (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=42707
> > Subject : Hang deconfiguring network interface (in shutdown) on 3.3-rc1
> > Submitter : James Bottomley <James.Bottomley@hansenpartnership•com>
> > Date : 2012-01-28 19:56 (27 days old)
> > Message-ID : <1327780565.2924.24.camel@dabdike•int.hansenpartnership.com>
> > References : http://marc.info/?l=linux-kernel&m=132778076214873&w=2
>
> Still present in 3.3-rc4; I've bisected it back to this commit:
>
> commit 92feeabf3f673767c6ee4cfc7fc224098446c1c1
> Author: Matt Carlson <mcarlson@broadcom•com>
> Date: Thu Dec 8 14:40:14 2011 +0000
>
> tg3: Save stats across chip resets
>
> and sure enough, just reverting this single commit on 3.3-rc4 fixes the
> problem.
>
> James
I don't see anything incorrect about the patch. I'm guessing the patch
just changes the timing somehow.
tg3_reset_chip() does not take any driver-internal spinlocks. That
happens at tg3_close(). I'm guessing the spinlock in the trace is coming
from synchronize_irq().
next prev parent reply other threads:[~2012-02-28 1:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:51 3.3-rc4+: Reported regressions from 3.2 Rafael J. Wysocki
2012-02-23 23:28 ` David Miller
2012-02-24 0:13 ` Rafael J. Wysocki
[not found] ` <qCQH7HfZS8E.A.x6F.98rRPB@chimera>
2012-02-27 23:44 ` [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1 James Bottomley
2012-02-28 1:24 ` Matt Carlson [this message]
[not found] ` <20120228012408.GA29622-+O+RPeR0w/SWJtbYL5oUVDJtLkR7yuzc@public.gmane.org>
2012-02-28 21:07 ` David Miller
[not found] ` <1330386274.2822.105.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2012-02-28 23:32 ` Matt Carlson
[not found] ` <20120228233225.GA1322-+O+RPeR0w/SWJtbYL5oUVDJtLkR7yuzc@public.gmane.org>
2012-02-29 0:58 ` James Bottomley
2012-02-29 9:33 ` Michael Chan
2012-02-29 18:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228012408.GA29622@mcarlson.broadcom.com \
--to=mcarlson@broadcom$(echo .)com \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=florian@mickler$(echo .)org \
--cc=kernel-testers@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maciej.rutecki@gmail$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rjw@sisk$(echo .)pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox