From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
To: Stefan Roese <sr@denx•de>
Cc: Rob Herring <robherring2@gmail•com>,
netdev@vger•kernel.org, Viresh Kumar <viresh.kumar@st•com>,
devicetree-discuss@ozlabs•org,
linux-arm-kernel@lists•infradead.org,
Giuseppe Cavallaro <peppe.cavallaro@st•com>
Subject: Re: [PATCH] stmmac: Add device-tree support
Date: Mon, 12 Mar 2012 16:14:37 +0100 [thread overview]
Message-ID: <20120312151437.GC13869@game.jcrosoft.org> (raw)
In-Reply-To: <201203121606.26926.sr@denx.de>
On 16:06 Mon 12 Mar , Stefan Roese wrote:
> Hi Rob,
>
> On Monday 12 March 2012 15:34:59 Rob Herring wrote:
> > On 03/12/2012 09:05 AM, Stefan Roese wrote:
> > > This patch adds support to configure the STMMAC ethernet driver via
> > > device-tree instead of platform_data.
> > >
> > > Currently, only the properties needed on SPEAr600 are provided. All
> > > other properties should be added once needed on other platforms.
> > >
> > > Signed-off-by: Stefan Roese <sr@denx•de>
> > > Cc: Giuseppe Cavallaro <peppe.cavallaro@st•com>
> > > Cc: Viresh Kumar <viresh.kumar@st•com>
> > > ---
> > >
> > > Documentation/devicetree/bindings/net/stmmac.txt | 38 +++++++++++
> > > .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 66
> > > +++++++++++++++++++- 2 files changed, 103 insertions(+), 1 deletion(-)
> > > create mode 100644 Documentation/devicetree/bindings/net/stmmac.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt
> > > b/Documentation/devicetree/bindings/net/stmmac.txt new file mode 100644
> > > index 0000000..386a47f
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/stmmac.txt
> > > @@ -0,0 +1,38 @@
> > > +* STMicroelectronics 10/100/1000 Ethernet driver (GMAC)
> > > +
> > > +Required properties:
> > > +- compatible: Should be "stm,gmac"
> >
> > This is too generic. This should be 1 string per version of h/w.
>
> Viresh, Giuseppe, can you please suggest a proper string for the SPEAr600
> STMMAC core, including version?
IIRC this IP is the same as the sti7108
st,sti7018-gmac
as this IP has been used first on SH4
Best Regards,
J.
next prev parent reply other threads:[~2012-03-12 15:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 14:05 [PATCH] stmmac: Add device-tree support Stefan Roese
2012-03-12 14:34 ` Rob Herring
2012-03-12 15:06 ` Stefan Roese
2012-03-12 15:14 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-03-12 15:30 ` Giuseppe CAVALLARO
2012-03-12 16:23 ` Stefan Roese
2012-03-12 16:46 ` Giuseppe CAVALLARO
2012-03-12 20:07 ` Rob Herring
2012-03-12 17:02 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <1331561157-3820-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
2012-03-12 14:38 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 15:25 ` Stefan Roese
2012-03-12 15:17 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 11:38 ` Giuseppe CAVALLARO
2012-03-14 13:07 ` Arnd Bergmann
2012-03-14 13:16 ` Giuseppe CAVALLARO
2012-03-14 13:37 ` Stefan Roese
2012-03-14 16:26 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-15 8:45 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312151437.GC13869@game.jcrosoft.org \
--to=plagnioj@jcrosoft$(echo .)com \
--cc=devicetree-discuss@ozlabs$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=robherring2@gmail$(echo .)com \
--cc=sr@denx$(echo .)de \
--cc=viresh.kumar@st$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox