From: Stephen Hemminger <shemminger@vyatta•com>
To: Knut Petersen <Knut_Petersen@t-online•de>,
"David S. Miller" <davem@davemloft•net>
Cc: Linus Torvalds <torvalds@linux-foundation•org>,
arekm@maven•pl, Jared <nitro@legroom•net>,
dilieto@lineone•net, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org
Subject: [PATCH] sky2: override for PCI legacy power management
Date: Wed, 21 Mar 2012 08:32:05 -0700 [thread overview]
Message-ID: <20120321083205.360a7a3b@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <4F69BE2E.7070903@t-online.de>
Some BIOS's don't setup power management correctly (what else is
new) and don't allow use of PCI Express power control. Add a special
exception module parameter to allow working around this issue.
Based on slightly different patch by Knut Petersen.
Reported-by: Arkadiusz Miskiewicz <arekm@maven•pl>
Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
---
Patch against -net (ie. 3.3.0)
--- a/drivers/net/ethernet/marvell/sky2.c 2012-01-10 10:56:56.855156017 -0800
+++ b/drivers/net/ethernet/marvell/sky2.c 2012-03-21 08:25:52.400929532 -0700
@@ -95,6 +95,10 @@ static int disable_msi = 0;
module_param(disable_msi, int, 0);
MODULE_PARM_DESC(disable_msi, "Disable Message Signaled Interrupt (MSI)");
+static int legacy_pme = 0;
+module_param(legacy_pme, int, 0);
+MODULE_PARM_DESC(legacy_pme, "Legacy power management");
+
static DEFINE_PCI_DEVICE_TABLE(sky2_id_table) = {
{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, 0x9000) }, /* SK-9Sxx */
{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, 0x9E00) }, /* SK-9Exx */
@@ -867,6 +871,13 @@ static void sky2_wol_init(struct sky2_po
/* Disable PiG firmware */
sky2_write16(hw, B0_CTST, Y2_HW_WOL_OFF);
+ /* Needed by some broken BIOSes, use PCI rather than PCI-e for WOL */
+ if (legacy_pme) {
+ u32 reg1 = sky2_pci_read32(hw, PCI_DEV_REG1);
+ reg1 |= PCI_Y2_PME_LEGACY;
+ sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
+ }
+
/* block receiver */
sky2_write8(hw, SK_REG(port, RX_GMF_CTRL_T), GMF_RST_SET);
sky2_read32(hw, B0_CTST);
next prev parent reply other threads:[~2012-03-21 15:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 11:40 [REGRESSION][PATCH] Fix an old sky2 WOL regression Knut Petersen
2012-03-21 15:08 ` Stephen Hemminger
2012-03-21 15:32 ` Stephen Hemminger [this message]
2012-03-21 15:56 ` [PATCH] sky2: override for PCI legacy power management Knut Petersen
2012-03-21 20:22 ` Bjorn Helgaas
2012-03-21 20:47 ` Stephen Hemminger
2012-03-21 20:54 ` Bjorn Helgaas
2012-03-22 22:36 ` Knut Petersen
2012-05-06 22:26 ` Jonathan Nieder
2012-03-21 20:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321083205.360a7a3b@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=Knut_Petersen@t-online$(echo .)de \
--cc=arekm@maven$(echo .)pl \
--cc=davem@davemloft$(echo .)net \
--cc=dilieto@lineone$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nitro@legroom$(echo .)net \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox