From: Oliver Neukum <oneukum-l3A5Bk7waGM@public•gmane.org>
To: Ming Lei <tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>
Cc: Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public•gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Fedora Kernel Team
<kernel-team-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public•gmane.org>,
Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>
Subject: Re: use-after-free in usbnet
Date: Thu, 22 Mar 2012 10:08:46 +0100 [thread overview]
Message-ID: <201203221008.46882.oneukum@suse.de> (raw)
In-Reply-To: <CACVXFVOVjnWjqpKxbU98DAyUC_OSb8ZL-3WcyYuFXgPJn5UyuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am Mittwoch, 21. März 2012, 17:22:59 schrieb Ming Lei:
> -
> + usb_get_urb(urb);
> spin_unlock_irqrestore(&q->lock, flags);
> // during some PM-driven resume scenarios,
> // these (async) unlinks complete immediately
> @@ -597,6 +597,7 @@ static int unlink_urbs (struct usbnet *dev, struct
> sk_buff_head *q)
> netdev_dbg(dev->net, "unlink urb err, %d\n", retval);
> else
> count++;
> + usb_put_urb(urb);
Hi,
this looks good, but could you add a comment explaining the reason for
taking a reference?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-22 9:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 15:12 use-after-free in usbnet Dave Jones
2012-03-20 9:40 ` Ming Lei
[not found] ` <CACVXFVN5O2S0hsnzHoi=LX+KAnccHc_F0SXq9-hMOXnaoUOdkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 1:04 ` Ming Lei
2012-03-21 1:34 ` Ming Lei
2012-03-21 14:35 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1203211031490.1369-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-03-21 15:02 ` Ming Lei
[not found] ` <CACVXFVP+U1k7JFTmbabF-k8F3bO9zc58c3tLG6=1nQPcrR9p1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 16:12 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1203211201560.1369-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-03-21 16:22 ` Ming Lei
[not found] ` <CACVXFVOVjnWjqpKxbU98DAyUC_OSb8ZL-3WcyYuFXgPJn5UyuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-21 17:30 ` Alan Stern
2012-03-22 9:08 ` Oliver Neukum [this message]
[not found] ` <201203221008.46882.oneukum-l3A5Bk7waGM@public.gmane.org>
2012-03-22 9:30 ` Ming Lei
2012-03-22 9:57 ` Oliver Neukum
2012-04-20 13:37 ` Huajun Li
2012-04-20 14:22 ` Ming Lei
[not found] ` <CACVXFVM5YBJkDZddeGi1_MPY7EqEV_wtoFy-NtBHYA6rxez0jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-20 14:56 ` Huajun Li
[not found] ` <CA+v9cxZWtGbz6uCSysVbAc1hT27rCiuJXzcvSiTxH-zuQYnrZw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-20 15:07 ` Huajun Li
2012-04-21 1:49 ` Ming Lei
2012-04-21 2:02 ` Ming Lei
[not found] ` <CACVXFVOc0XZ+eLHGiVwKuiUResRk8Cj9MS4EPMx7k57a0tEJhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-21 6:39 ` Huajun Li
[not found] ` <CA+v9cxZZpL5soSga=MX_bD45KNve-Lnr2Qb6+gr7Mv6Txyh-fA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-21 7:06 ` Ming Lei
[not found] ` <CACVXFVN6kvXk7s4Sc0d_-yKSM=rV3qcuPPBHVZYzoQjnwkGX+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-21 7:45 ` Ming Lei
[not found] ` <CACVXFVNc_S8pTaBqMzQZx6Dt-tSP_9iXepxJzv=iR9BFu=Tj8g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-21 8:00 ` Huajun Li
2012-04-22 2:19 ` Huajun Li
2012-04-22 12:05 ` Ming Lei
2012-04-22 13:15 ` Huajun Li
[not found] ` <CA+v9cxZfzATWynXGtEe6gvcD2aRsLqAF3ZN_HM_dyU4W_rQSpg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-22 14:10 ` Ming Lei
2012-04-22 14:15 ` Ming Lei
2012-04-22 14:19 ` Ming Lei
2012-04-21 7:50 ` Huajun Li
[not found] ` <CA+v9cxa+fyzMOD-=oLLczpu1FDtTwcok+y2FkC=mHzDH3JYJ2A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-21 7:56 ` Ming Lei
[not found] ` <CACVXFVOMTbq0zbmsZAt-Pyc=3oqQ=UcWV5HgNryu7s6oMhKpQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-21 8:23 ` Huajun Li
[not found] ` <CA+v9cxZRpthaZ=64tLzKf=AGOqaRVwe5o0UMadiXGuiuXiA7uA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-21 9:40 ` Ming Lei
[not found] ` <CACVXFVOemJqfT9OPRer3qzbVEsGyUOupoOUNCBzC4deNRsksQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-22 2:02 ` Huajun Li
2012-04-21 19:23 ` David Miller
[not found] ` <20120421.152345.290988116097275353.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-04-22 1:45 ` Huajun Li
2012-04-22 2:05 ` David Miller
[not found] ` <CA+v9cxawVwKakF6c_RpAw2XUGWcbqd8M+ZJqyq76Au9rmNosmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-04-26 5:02 ` Ming Lei
2012-04-26 16:30 ` Huajun Li
2012-03-21 14:44 ` Greg KH
2012-03-21 15:07 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203221008.46882.oneukum@suse.de \
--to=oneukum-l3a5bk7wagm@public$(echo .)gmane.org \
--cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=kernel-team-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public$(echo .)gmane.org \
--cc=tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox