From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Ming Lei <tom.leiming@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, linux-usb@vger•kernel.org,
stable@kernel•org,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>,
Alan Stern <stern@rowland•harvard.edu>,
Oliver Neukum <oliver@neukum•org>
Subject: Re: [PATCH 1/2] usbnet: increase URB reference count before usb_unlink_urb
Date: Thu, 22 Mar 2012 07:35:53 -0700 [thread overview]
Message-ID: <20120322143553.GC19835@kroah.com> (raw)
In-Reply-To: <1332422538-6597-1-git-send-email-tom.leiming@gmail.com>
On Thu, Mar 22, 2012 at 09:22:18PM +0800, Ming Lei wrote:
> Commit 4231d47e6fe69f061f96c98c30eaf9fb4c14b96d(net/usbnet: avoid
> recursive locking in usbnet_stop()) fixes the recursive locking
> problem by releasing the skb queue lock, but it makes usb_unlink_urb
> racing with defer_bh, and the URB to being unlinked may be freed before
> or during calling usb_unlink_urb, so use-after-free problem may be
> triggerd inside usb_unlink_urb.
>
> The patch fixes the use-after-free problem by increasing URB
> reference count with skb queue lock held before calling
> usb_unlink_urb, so the URB won't be freed until return from
> usb_unlink_urb.
>
> Cc: stable@kernel•org
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix•de>
> Cc: Alan Stern <stern@rowland•harvard.edu>
> Cc: Oliver Neukum <oliver@neukum•org>
> Reported-by: Dave Jones <davej@redhat•com>
> Signed-off-by: Ming Lei <tom.leiming@gmail•com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
next prev parent reply other threads:[~2012-03-22 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 13:22 [PATCH 1/2] usbnet: increase URB reference count before usb_unlink_urb Ming Lei
2012-03-22 14:35 ` Greg Kroah-Hartman [this message]
[not found] ` <20120322143553.GC19835-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-03-22 23:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322143553.GC19835@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=bigeasy@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oliver@neukum$(echo .)org \
--cc=stable@kernel$(echo .)org \
--cc=stern@rowland$(echo .)harvard.edu \
--cc=tom.leiming@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox