From: Dan Carpenter <dan.carpenter@oracle•com>
To: rusty@rustcorp•com.au
Cc: netdev@vger•kernel.org
Subject: re: module_param: make bool parameters really bool (net & drivers/net)
Date: Thu, 22 Mar 2012 21:26:23 +0300 [thread overview]
Message-ID: <20120322182623.GA29859@elgon.mountain> (raw)
Hi Rusty,
The patch eb93992207da: "module_param: make bool parameters really
bool (net & drivers/net)" from Dec 19, 2011, leads to the following
warning:
net/ipv4/netfilter/iptable_filter.c:90 iptable_filter_init()
warn: 5 is more than 1 (max 'forward' can be) so this is
always the same.
It's declared like this:
54 /* Default to forward because I got too much mail already. */
55 static bool forward = NF_ACCEPT;
56 module_param(forward, bool, 0000);
It's used like this:
66 ((struct ipt_standard *)repl->entries)[1].target.verdict = -forward - 1;
Smatch complains when check that it's larger than 5.
90 if (forward < 0 || forward > NF_MAX_VERDICT) {
91 pr_err("iptables forward must be 0 or 1\n");
92 return -EINVAL;
93 }
regards,
dan carpenter
next reply other threads:[~2012-03-22 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 18:26 Dan Carpenter [this message]
2012-03-22 18:30 ` module_param: make bool parameters really bool (net & drivers/net) Dan Carpenter
2012-03-22 22:07 ` Rusty Russell
2012-03-22 22:27 ` [PATCH] netfilter: remove forward module param confusion Rusty Russell
2012-03-23 2:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322182623.GA29859@elgon.mountain \
--to=dan.carpenter@oracle$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox