From: Stephen Hemminger <shemminger@vyatta•com>
To: David Miller <davem@davemloft•net>
Cc: shanwei88@gmail•com, xemul@parallels•com, netdev@vger•kernel.org
Subject: Re: [PATCH] unix_diag: use netlink attribute MAX convention
Date: Wed, 25 Apr 2012 11:56:09 -0700 [thread overview]
Message-ID: <20120425115609.4ef9ece0@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20120425.141658.1934757959636497552.davem@davemloft.net>
On Wed, 25 Apr 2012 14:16:58 -0400 (EDT)
David Miller <davem@davemloft•net> wrote:
> From: Stephen Hemminger <shemminger@vyatta•com>
> Date: Wed, 25 Apr 2012 10:38:58 -0700
>
> > Use the standard convention to define the number of elements
> > in unix diag attribute. This fixes future problems like the fact
> > the last element (MEMINFO) is not parsed by current iproute2 ss command.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta•com>
>
> You can't change this, it's already out in the wild, and
> for 2 releases.
>
> Sorry.
>
> Just accept the 'ss' patch that was posted and you objected to,
> I'm not breaking userspace just so that you don't have to apply
> a userland patch you perceive as an unacceptable quirk.
It only changes a broken enum value used only by iproute2.
Do you expect the one utility to use it to have a workaround for
a broken initial version.
next prev parent reply other threads:[~2012-04-25 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 7:15 [PATCH 1/2] ss: fix the incorrect value of total UNIX_DIAG_* number Shan Wei
2012-04-25 16:26 ` Stephen Hemminger
2012-04-25 17:38 ` [PATCH] unix_diag: use netlink attribute MAX convention Stephen Hemminger
2012-04-25 18:16 ` David Miller
2012-04-25 18:56 ` Stephen Hemminger [this message]
2012-04-25 19:07 ` David Miller
2012-04-25 19:47 ` Stephen Hemminger
2012-04-25 19:57 ` David Miller
2012-04-25 20:09 ` Stephen Hemminger
2012-04-25 20:12 ` David Miller
2012-04-25 20:21 ` [PATCH 1/2] ss: fix the incorrect value of total UNIX_DIAG_* number Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425115609.4ef9ece0@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shanwei88@gmail$(echo .)com \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox