From: Jiri Bohac <jbohac@suse•cz>
To: Jay Vosburgh <fubar@us•ibm.com>
Cc: Jiri Bohac <jbohac@suse•cz>,
Eric Dumazet <eric.dumazet@gmail•com>,
Andy Gospodarek <andy@greyhouse•net>,
netdev@vger•kernel.org
Subject: Re: bonding: don't increase rx_dropped after processing LACPDUs
Date: Fri, 4 May 2012 14:15:45 +0200 [thread overview]
Message-ID: <20120504121545.GA32665@midget.suse.cz> (raw)
In-Reply-To: <1765.1336000239@death.nxdomain>
On Wed, May 02, 2012 at 04:10:39PM -0700, Jay Vosburgh wrote:
> Won't this make it impossible to bind a PF_PACKET socket to
> sll_protocol == ETH_P_SLOW and see the LACPDUs, but only when bonding is
> running 802.3ad?
yes it will...
> This because the ptype_all check in
> __netif_receive_skb happens before the rx_handler, but the ptype_base
> check (bound packet socket, for example) happens after. Currently,
> libpcap looks to bind to ETH_P_ALL, so it won't be affected.
Does it make any sense for the packet socket not to bind to
ETH_P_ALL? With all the rx_handlers interfering with the packet
(e.g. modifying skb->dev, modifying the MAC address), binding to
ETH_P_SLOW will never reliably get you the the original frame
with reliable information about the incoming device.
> If so, is that something we care about?
I think not.
--
Jiri Bohac <jbohac@suse•cz>
SUSE Labs, SUSE CZ
next prev parent reply other threads:[~2012-05-04 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 20:23 bonding: don't increase rx_dropped after processing LACPDUs Jiri Bohac
2012-05-02 20:36 ` Eric Dumazet
2012-05-02 20:51 ` Jiri Bohac
2012-05-02 23:10 ` Jay Vosburgh
2012-05-04 12:15 ` Jiri Bohac [this message]
2012-05-02 23:41 ` David Miller
2012-05-04 12:16 ` Jiri Bohac
2012-05-04 12:19 ` [PATCH v2] " Jiri Bohac
2012-05-04 13:04 ` Eric Dumazet
2012-05-04 13:28 ` [PATCH v3] " Jiri Bohac
2012-05-04 14:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504121545.GA32665@midget.suse.cz \
--to=jbohac@suse$(echo .)cz \
--cc=andy@greyhouse$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox