From: "Michael S. Tsirkin" <mst@redhat•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
"Jamal Hadi Salim" <hadi@cyberus•ca>,
"Stephen Hemminger" <shemminger@vyatta•com>,
"Jason Wang" <jasowang@redhat•com>,
"Neil Horman" <nhorman@tuxdriver•com>,
"Jiri Pirko" <jpirko@redhat•com>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel•com>,
"Michał Mirosław" <mirq-linux@rere•qmqm.pl>,
"Ben Hutchings" <bhutchings@solarflare•com>,
"Herbert Xu" <herbert@gondor•hengli.com.au>
Subject: Re: [PATCH] net: orphan queued skbs if device tx can stall
Date: Tue, 8 May 2012 22:35:08 +0300 [thread overview]
Message-ID: <20120508193507.GC28536@redhat.com> (raw)
In-Reply-To: <1334065929.5300.40.camel@edumazet-glaptop>
On Tue, Apr 10, 2012 at 03:52:09PM +0200, Eric Dumazet wrote:
> By the way, skb orphaning should already be done in skb_orphan_try(),
> not sure why its done again in tun_net_xmit().
Because we need to force it for skbs which have tx_flags set.
> Note we perform orphaning
> right before giving skb to device on premise it'll be sent (and freed)
> in a reasonable amount of time.
It is usually the case. I think this assumption holds for
tun normally.
next prev parent reply other threads:[~2012-05-08 19:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 17:13 [PATCH] net: orphan queued skbs if device tx can stall Michael S. Tsirkin
2012-04-08 23:49 ` Herbert Xu
2012-04-09 7:28 ` Michael S. Tsirkin
2012-04-09 7:33 ` Herbert Xu
2012-04-09 7:39 ` Michael S. Tsirkin
2012-04-09 8:29 ` Herbert Xu
2012-04-09 8:34 ` Michael S. Tsirkin
2012-04-09 8:39 ` Herbert Xu
2012-04-09 8:42 ` Michael S. Tsirkin
2012-04-09 9:13 ` Eric Dumazet
2012-04-10 7:55 ` Eric Dumazet
2012-04-10 8:41 ` Michael S. Tsirkin
2012-04-10 8:55 ` Eric Dumazet
2012-04-10 9:31 ` Michael S. Tsirkin
2012-04-10 10:04 ` Eric Dumazet
2012-04-10 11:25 ` Michael S. Tsirkin
2012-04-10 11:45 ` Eric Dumazet
2012-04-10 12:41 ` Michael S. Tsirkin
2012-04-10 13:52 ` Eric Dumazet
2012-04-10 14:10 ` Michael S. Tsirkin
2012-04-11 21:52 ` Michael S. Tsirkin
2012-05-08 19:35 ` Michael S. Tsirkin [this message]
2012-05-08 19:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508193507.GC28536@redhat.com \
--to=mst@redhat$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=hadi@cyberus$(echo .)ca \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=jasowang@redhat$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jpirko@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mirq-linux@rere$(echo .)qmqm.pl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox