Subject: Re: [PATCH V2] CS89x0 : Use ioread16/iowrite16 on all platforms

From: Arnd Bergmann <[email-masked]>
Date: Tue, 15 May 2012 21:22:15 +0000

On Tuesday 15 May 2012, Jaccon Bastiaansen wrote:
> 
> The use of the inw/outw functions by the cs89x0 platform driver
> results in NULL pointer references on ARM platforms and
> platforms that do not provide ISA-style programmed I/O accessors.
> 
> Using inw/outw also accesses the wrong address space on platforms
> that have a PCI I/O space that is not identity-mapped into the
> physical address space.
> 
> Signed-off-by: Jaccon Bastiaansen <[email-masked]>

Looks good to me now.

Acked-by: Arnd Bergmann <[email-masked]>

Of course we would need some testing on another platform and ideally
also on an ISA based machine, although that might be hard to
come by these days...

	Arnd