From: Fengguang Wu <wfg-VuQAYsv1563Yd54FQh9/CA@public•gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public•gmane.org
Subject: Re: [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c
Date: Sun, 10 Jun 2012 10:37:36 +0800 [thread overview]
Message-ID: <20120610023736.GA9908@localhost> (raw)
In-Reply-To: <20120609.221801.2226110181753212240.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Sat, Jun 09, 2012 at 10:18:01PM -0400, David Miller wrote:
> From: David Miller <davem@davemloft•net>
> Date: Sat, 09 Jun 2012 19:09:29 -0700 (PDT)
>
> > From: Fengguang Wu <wfg@linux•intel.com>
> > Date: Sun, 10 Jun 2012 10:08:01 +0800
> >
> >> And in another config, an old error still triggers:
> >>
> >> net/ipv4/inetpeer.c: In function ‘family_to_base’:
> >> net/ipv4/inetpeer.c:397:50: error: ‘struct net’ has no member named ‘ipv6’
> >> net/ipv4/inetpeer.c:398:1: warning: control reaches end of non-void function [-Wreturn-type]
> >>
> >> I'm building this patch on top of net-next master.
> >
> > What a fucking mess Gao created, I'll fix this.
> >
> > Thanks for the report.
>
> I just pushed the following to net-next:
>
> --------------------
> inet: Pass inetpeer root into inet_getpeer*() interfaces.
>
> Otherwise we reference potentially non-existing members when
> ipv6 is disabled.
>
> Signed-off-by: David S. Miller <davem@davemloft•net>
> ---
> include/net/inetpeer.h | 10 +++++-----
> net/ipv4/inetpeer.c | 9 +--------
> net/ipv4/ip_fragment.c | 2 +-
> net/ipv4/route.c | 6 +++---
> net/ipv6/route.c | 2 +-
> 5 files changed, 11 insertions(+), 18 deletions(-)
David,
There will be a delay before I can see and pull the change. But anyway
new build tests should be kicked off automatically after a while.
Any new errors/warnings will be automatically reported to you and the
mailing list. In future build errors in these 4 trees will be CCed to
the netdev mailing list:
netdev@vger•kernel.org git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
netdev@vger•kernel.org git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
netdev@vger•kernel.org git://git.kernel.org/pub/scm/linux/kernel/git/kkeil/isdn-2.6.git
netdev@vger•kernel.org git://git.kernel.org/pub/scm/linux/kernel/git/sameo/irda-2.6.git
Thanks,
Fengguang
_______________________________________________
Containers mailing list
Containers@lists•linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers
next prev parent reply other threads:[~2012-06-10 2:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 23:32 [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c David Miller
2012-06-10 1:58 ` Fengguang Wu
2012-06-10 2:04 ` David Miller
[not found] ` <20120609.190451.182034193302304295.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-10 3:16 ` Fengguang Wu
2012-06-10 4:21 ` David Miller
[not found] ` <20120609.212147.1738198233131370927.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-10 4:43 ` Fengguang Wu
2012-06-10 4:49 ` Fengguang Wu
2012-06-10 5:04 ` David Miller
[not found] ` <20120609.220421.2043389435765629622.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-10 6:47 ` Fengguang Wu
2012-06-10 5:03 ` David Miller
2012-06-10 2:08 ` Fengguang Wu
2012-06-10 2:09 ` David Miller
[not found] ` <20120609.190929.1165462964087672866.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-10 2:18 ` David Miller
[not found] ` <20120609.221801.2226110181753212240.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-06-10 2:37 ` Fengguang Wu [this message]
2012-06-10 10:16 ` Fengguang Wu
2012-06-11 0:27 ` [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4, 6}/route.c Gao feng
[not found] ` <4FD53B74.1050409-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-06-11 1:44 ` [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4,6}/route.c Fengguang Wu
2012-06-11 3:03 ` David Miller
2012-06-10 5:14 ` [PATCH] inet: Initialize per-netns inetpeer roots in net/ipv{4, 6}/route.c Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120610023736.GA9908@localhost \
--to=wfg-vuqaysv1563yd54fqh9/ca@public$(echo .)gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox