From: Steffen Klassert <steffen.klassert@secunet•com>
To: Saurabh Mohan <saurabh.mohan@vyatta•com>
Cc: netdev@vger•kernel.org
Subject: Re: [net-next PATCH 02/02] net/ipv4: VTI support new module for ip_vti.
Date: Fri, 15 Jun 2012 07:37:07 +0200 [thread overview]
Message-ID: <20120615053707.GV27795@secunet.com> (raw)
In-Reply-To: <c2becb86-be73-4668-be84-82293c6c56fc@tahiti.vyatta.com>
On Thu, Jun 14, 2012 at 07:43:59PM -0700, Saurabh Mohan wrote:
> > +
> > + iph->version = 4;
> > + iph->protocol = IPPROTO_ESP;
>
> Why IPPROTO_ESP? What's with the other IPsec protocols?
> Shouldn't this be IPPROTO_IPIP?
>
> @SM: VTI will work only with ESP not with AH (at least I have never heard of any one using it with AH). Plus I wanted to keep this module separate from IPIP (ip-in-ip tunnels).
>
VTI should be independent of the IPsec protocol.
Our IPsec implementation supports AH (and IPCOMP)
so VTI should support these protocols too.
next prev parent reply other threads:[~2012-06-15 5:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 17:32 [net-next PATCH 02/02] net/ipv4: VTI support new module for ip_vti Saurabh
2012-06-14 9:12 ` Steffen Klassert
2012-06-15 2:43 ` Saurabh Mohan
2012-06-15 3:50 ` David Miller
2012-06-15 5:37 ` Steffen Klassert [this message]
2012-06-16 1:12 ` Saurabh Mohan
2012-06-17 23:27 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-06-28 1:02 Saurabh
2012-06-28 1:19 ` David Miller
2012-06-28 8:04 ` Steffen Klassert
2012-06-29 0:52 Saurabh
2012-06-29 1:07 ` David Miller
2012-06-29 1:30 Saurabh
2012-07-09 6:47 ` David Miller
2012-07-17 19:44 Saurabh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615053707.GV27795@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=saurabh.mohan@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox