Subject: Re: [PATCH net-next v2 01/12] netfilter: fix problem with proto register

From: Pablo Neira Ayuso <[email-masked]>
Date: Mon, 18 Jun 2012 11:06:31 +0200

On Mon, Jun 18, 2012 at 08:59:11AM +0800, Gao feng wrote:
> 于 2012年06月16日 18:50, Pablo Neira Ayuso 写道:
> > On Sat, Jun 16, 2012 at 11:41:12AM +0800, Gao feng wrote:
> >> commit 2c352f444ccfa966a1aa4fd8e9ee29381c467448
> >> (netfilter: nf_conntrack: prepare namespace support for
> >> l4 protocol trackers) register proto before register sysctl.
> >>
> >> it changes the behavior that when register sysctl failed, the
> >> proto should not be registered too.
> >>
> >> so change to register sysctl before register protos.
> > 
> > Could you explain why we need to change the order in the registration?
> > ie. now first proto->init_net then sysctl things.
> 
> before commit 2c352f444ccfa966a1aa4fd8e9ee29381c467448, we register sysctl before
> register protos, so if sysctl is registered faild, the protos will not be registered.
> 
> but now, we register protos first, and when register sysctl failed, we can use protos
> too, it's different from before.

That makes sense.

IMO, this is the thing that should be included in the description.