Subject: Re: [PATCH] netxen: Error return off by one in 'netxen_nic_set_pauseparam()'.

From: Dan Carpenter <[email-masked]>
Date: Wed, 20 Jun 2012 10:44:47 +0300

On Wed, Jun 20, 2012 at 12:57:39PM +0530, santosh nayak wrote:
> From: Santosh Nayak <[email-masked]>
> 
> There are 'NETXEN_NIU_MAX_GBE_PORTS'  GBE ports. Port indexing starts
> from zero. 
> Hence we should also return error for "port == NETXEN_NIU_MAX_GBE_PORTS"
> 

I don't know this code well enough to say if you are right or not,
but what about for port == NETXEN_NIU_MAX_XG_PORTS a few lines later
in both functions?

regards,
dan carpenter