Subject: Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB

From: Oliver Neukum <[email-masked]>
Date: Wed, 20 Jun 2012 10:58:55 +0200

Am Mittwoch, 20. Juni 2012, 10:07:55 schrieb Ming Lei:
> On Wed, Jun 20, 2012 at 4:00 PM, Oliver Neukum <[email-masked]> wrote:
> >
> > Very well, on second thought, this patch makes sense.
> > Could you resend and I'll ack?
> 
> BTW, maybe it is better to add below
> 
>     usbnet_defer_kevent(dev, EVENT_STS_HALT);
> 
> for -EPIPE returned from usb_urb_submit if it will be resent.

Why? If it failed once it'll probably also fail the next time.
In that case we'd need to do something more intrusive
like resetting the device, but that cannot be done well
in the generic usbnet part.

	Regards
		Oliver