From: Stephen Hemminger <shemminger@vyatta•com>
To: David Miller <davem@davemloft•net>
Cc: tgraf@suug•ch, netdev@vger•kernel.org
Subject: Re: [PATCH 7/7] netlink: Get rid of obsolete rtnetlink macros
Date: Wed, 27 Jun 2012 15:31:45 -0700 [thread overview]
Message-ID: <20120627153145.1379a30b@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20120627.150435.67648216442174370.davem@davemloft.net>
On Wed, 27 Jun 2012 15:04:35 -0700 (PDT)
David Miller <davem@davemloft•net> wrote:
> From: Stephen Hemminger <shemminger@vyatta•com>
> Date: Wed, 27 Jun 2012 08:35:32 -0700
>
> > On Wed, 27 Jun 2012 11:36:16 +0200
> > Thomas Graf <tgraf@suug•ch> wrote:
> >
> >> Removes all RTA_GET*() and RTA_PUT*() variations, as well as the
> >> the unused rtattr_strcmp(). Get rid of rtm_get_table() by moving
> >> it to its only user decnet.
> >>
> >> Signed-off-by: Thomas Graf <tgraf@suug•ch>
> >> ---
> >
> > Nack. The RTA_ macros are exported to user space through kernel
> > headers process. If you do this it will break iproute2 build.
> >
>
> They are protected by __KERNEL__, what are you talking about?
Never mind, there are copies in other places in iproute
I plan to get rid of the macro versions of this stuff.
It is a nuisance in iproute for the same reason as the kernel.
next prev parent reply other threads:[~2012-06-27 22:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 9:36 [PATCH 0/7] Get rid of RTA*() macros Thomas Graf
2012-06-27 9:36 ` [PATCH 1/7] unix_diag: Do not use RTA_PUT() macros Thomas Graf
2012-06-27 9:36 ` [PATCH 2/7] sock_diag: " Thomas Graf
2012-06-27 10:00 ` David Laight
2012-06-27 10:07 ` David Miller
2012-06-27 10:07 ` Thomas Graf
2012-06-27 9:36 ` [PATCH 3/7] inet_diag: " Thomas Graf
2012-06-27 9:36 ` [PATCH 4/7] ipmr: " Thomas Graf
2012-06-27 9:36 ` [PATCH 5/7] ip6mr: " Thomas Graf
2012-06-27 9:36 ` [PATCH 6/7] decnet: " Thomas Graf
2012-06-27 9:36 ` [PATCH 7/7] netlink: Get rid of obsolete rtnetlink macros Thomas Graf
2012-06-27 15:35 ` Stephen Hemminger
2012-06-27 22:04 ` David Miller
2012-06-27 22:31 ` Stephen Hemminger [this message]
2012-06-27 22:37 ` [PATCH 0/7] Get rid of RTA*() macros David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627153145.1379a30b@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox