From: Steffen Klassert <steffen.klassert@secunet•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH 09/15] ipv4: Cache output routes in fib_info nexthops.
Date: Thu, 19 Jul 2012 13:38:10 +0200 [thread overview]
Message-ID: <20120719113810.GM1869@secunet.com> (raw)
In-Reply-To: <20120718.112404.1910372180742347127.davem@davemloft.net>
On Wed, Jul 18, 2012 at 11:24:04AM -0700, David Miller wrote:
> +
> +static void rt_bind_exception(struct rtable *rt, struct fib_nh_exception *fnhe)
> +{
> + if (fnhe->fnhe_pmtu) {
> + unsigned long expires = fnhe->fnhe_expires;
> + unsigned long diff = jiffies - expires;
This should be diff = expires - jiffies
With that changed, everything seems to work fine :)
> +
> + if (time_before(jiffies, expires)) {
> + rt->rt_pmtu = fnhe->fnhe_pmtu;
> + dst_set_expires(&rt->dst, diff);
> }
> }
> + if (fnhe->fnhe_gw) {
> + rt->rt_flags |= RTCF_REDIRECTED;
> + rt->rt_gateway = fnhe->fnhe_gw;
> + }
> + fnhe->fnhe_stamp = jiffies;
> }
>
next prev parent reply other threads:[~2012-07-19 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 18:24 [PATCH 09/15] ipv4: Cache output routes in fib_info nexthops David Miller
2012-07-18 20:34 ` Eric Dumazet
2012-07-18 20:36 ` David Miller
2012-07-18 20:40 ` Eric Dumazet
2012-07-18 20:49 ` David Miller
2012-07-19 11:38 ` Steffen Klassert [this message]
2012-07-19 15:39 ` David Miller
2012-07-19 15:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719113810.GM1869@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox