From: Greg KH <gregkh@linuxfoundation•org>
To: Arun Murthy <arun.murthy@stericsson•com>
Cc: linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linux-doc@vger•kernel.org, sjur.brandeland@stericsson•com
Subject: Re: [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver
Date: Tue, 7 Aug 2012 11:39:25 -0700 [thread overview]
Message-ID: <20120807183925.GD26990@kroah.com> (raw)
In-Reply-To: <1344322471-3640-4-git-send-email-arun.murthy@stericsson.com>
On Tue, Aug 07, 2012 at 12:24:30PM +0530, Arun Murthy wrote:
> The communication between APE and CMT in u8500 is by means of a shared DDR.
> Since its a shared memory, this driver implements shrm protocol.
>
> Signed-off-by: Arun Murthy <arun.murthy@stericsson•com>
> Acked-by: Linus Walleij <linus.walleij@stericsson•com>
> ---
> drivers/modem_shm/Kconfig | 2 +
> drivers/modem_shm/Makefile | 1 +
> drivers/modem_shm/u8500_shm/Kconfig | 43 +
> drivers/modem_shm/u8500_shm/Makefile | 7 +
> drivers/modem_shm/u8500_shm/shrm_char.c | 895 ++++++++++++
> drivers/modem_shm/u8500_shm/shrm_driver.c | 732 ++++++++++
> drivers/modem_shm/u8500_shm/shrm_fifo.c | 837 ++++++++++++
> drivers/modem_shm/u8500_shm/shrm_net.c | 312 +++++
> drivers/modem_shm/u8500_shm/shrm_protocol.c | 1590 ++++++++++++++++++++++
> include/linux/modem_shm/u8500_shm/shrm.h | 23 +
> include/linux/modem_shm/u8500_shm/shrm_config.h | 114 ++
> include/linux/modem_shm/u8500_shm/shrm_driver.h | 225 +++
> include/linux/modem_shm/u8500_shm/shrm_ioctl.h | 43 +
> include/linux/modem_shm/u8500_shm/shrm_net.h | 46 +
> include/linux/modem_shm/u8500_shm/shrm_private.h | 183 +++
Why do any of those .h files need to be in include/linux/*? Shouldn't
they just be in the same directory as the driver itself?
greg k-h
next prev parent reply other threads:[~2012-08-07 18:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 6:54 [PATCHv2 0/4] modem_shm: U8500 SHaRed Memory driver(SHRM) Arun Murthy
2012-08-07 6:54 ` [PATCHv2 1/4] modem_shm: Add Modem Access Framework Arun Murthy
2012-08-07 18:38 ` Greg KH
2012-08-08 3:36 ` Arun MURTHY
2012-08-08 13:37 ` Greg KH
2012-08-09 9:53 ` Arun MURTHY
2012-08-09 11:38 ` Alan Cox
2012-08-13 13:33 ` Linus Walleij
2012-08-09 10:14 ` Arun MURTHY
2012-08-07 6:54 ` [PATCHv2 2/4] modem_shm: Register u8500 client for MAF Arun Murthy
2012-08-07 6:54 ` [PATCHv2 3/4] modem_shm: u8500-shm: U8500 Shared Memory Driver Arun Murthy
2012-08-07 10:01 ` Alan Cox
2012-08-08 3:03 ` Arun MURTHY
2012-08-08 10:46 ` Alan Cox
2012-08-09 10:11 ` Arun MURTHY
2012-08-07 18:39 ` Greg KH [this message]
2012-08-08 3:36 ` Arun MURTHY
2012-08-07 6:54 ` [PATCHv2 4/4] Doc: Add u8500_shrm document Arun Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807183925.GD26990@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=arun.murthy@stericsson$(echo .)com \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sjur.brandeland@stericsson$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox