From: Jiri Pirko <jiri@resnulli•us>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net, edumazet@google•com,
faisal.latif@intel•com, roland@kernel•org, sean.hefty@intel•com,
hal.rosenstock@gmail•com, fubar@us•ibm.com, andy@greyhouse•net,
divy@chelsio•com, jitendra.kalsaria@qlogic•com,
sony.chacko@qlogic•com, linux-driver@qlogic•com, kaber@trash•net,
ursula.braun@de•ibm.com, blaschka@linux•vnet.ibm.com,
linux390@de•ibm.com, shemminger@vyatta•com,
bhutchings@solarflare•com, therbert@google•com, joe@perches•com,
gregory.v.rose@intel•com, john.r.fastabend@intel•com,
linux-rdma@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-s390@vger•kernel.org, bridge@lists•linux-foundation.org,
fbl@redhat•com
Subject: Re: [patch net-next 01/16] net: introduce upper device lists
Date: Tue, 14 Aug 2012 12:18:52 +0200 [thread overview]
Message-ID: <20120814101852.GA1661@minipsycho.brq.redhat.com> (raw)
In-Reply-To: <502A1429.9060005@gmail.com>
Tue, Aug 14, 2012 at 11:02:33AM CEST, xiyou.wangcong@gmail•com wrote:
>On 08/13/2012 11:27 PM, Jiri Pirko wrote:
>>This lists are supposed to serve for storing pointers to all upper devices.
>>Eventually it will replace dev->master pointer which is used for
>>bonding, bridge, team but it cannot be used for vlan, macvlan where
>>there might be multiple "masters" present.
>>
>>New upper device list resolves this limitation. Also, the information
>>stored in lists is used for preventing looping setups like
>>"bond->somethingelse->samebond"
>
>Hi, Jiri,
>
>I have some difficulty to understand this patch description, so take
>bridged bonding as an example, IIUC, both the bridge dev and bonding
>dev will be in the upper dev list of eth0 and eth1? And br0 will be
>in the upper dev list of bond0 too?
No. Only direct upper device is in the list.
>
>I think it would be nice to describe the hierarchy after your patches.
Hierarchy is the same after.
>
>Thanks!
>
next prev parent reply other threads:[~2012-08-14 10:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 15:26 [patch net-next 00/16] net: introduce upper device lists and remove dev->master Jiri Pirko
[not found] ` <1344871635-1052-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2012-08-13 15:27 ` [patch net-next 01/16] net: introduce upper device lists Jiri Pirko
[not found] ` <1344871635-1052-2-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2012-08-13 17:04 ` Ben Hutchings
2012-08-13 17:31 ` Jiri Pirko
2012-08-15 20:33 ` Nicolas de Pesloüan
2012-08-14 9:02 ` Cong Wang
2012-08-14 10:18 ` Jiri Pirko [this message]
2012-08-13 17:52 ` Flavio Leitner
2012-08-14 12:24 ` Jiri Pirko
2012-08-14 13:14 ` Flavio Leitner
2012-08-14 13:35 ` Jiri Pirko
2012-08-13 15:27 ` [patch net-next 02/16] macvlan: add link to upper device Jiri Pirko
2012-08-13 15:27 ` [patch net-next 03/16] vlan: " Jiri Pirko
2012-08-13 19:04 ` Flavio Leitner
[not found] ` <20120813160421.77a74e4e-8Luz0qD3JK/tRgLqZ5aouw@public.gmane.org>
2012-08-14 7:24 ` Jiri Pirko
2012-08-13 15:27 ` [patch net-next 04/16] rtnetlink: remove usage of dev->master Jiri Pirko
2012-08-13 15:27 ` [patch net-next 05/16] team: remove usage of netdev_set_master() Jiri Pirko
2012-08-13 15:27 ` [patch net-next 06/16] bridge: " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 07/16] netpoll: remove usage of dev->master Jiri Pirko
2012-08-13 15:27 ` [patch net-next 08/16] cxgb3: " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 09/16] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock Jiri Pirko
2012-08-13 15:27 ` [patch net-next 10/16] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock Jiri Pirko
2012-08-13 15:27 ` [patch net-next 11/16] vlan: remove usage of dev->master in __vlan_find_dev_deep() Jiri Pirko
2012-08-13 15:27 ` [patch net-next 12/16] nes: remove usage of dev->master Jiri Pirko
2012-08-13 15:27 ` [patch net-next 13/16] bonding: " Jiri Pirko
2012-08-13 15:27 ` [patch net-next 14/16] net: remove no longer used netdev_set_bond_master() and netdev_set_master() Jiri Pirko
2012-08-13 15:27 ` [patch net-next 15/16] net: remove usage of dev->master Jiri Pirko
[not found] ` <1344871635-1052-16-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2012-08-13 17:15 ` Ben Hutchings
[not found] ` <1344878131.2733.28.camel-/LGg1Z1CJKReKY3V0RtoKmatzQS1i7+A3tAM5lWOD0I@public.gmane.org>
2012-08-13 17:31 ` Jiri Pirko
2012-08-13 15:27 ` [patch net-next 16/16] net: kill dev->master Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814101852.GA1661@minipsycho.brq.redhat.com \
--to=jiri@resnulli$(echo .)us \
--cc=andy@greyhouse$(echo .)net \
--cc=bhutchings@solarflare$(echo .)com \
--cc=blaschka@linux$(echo .)vnet.ibm.com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=divy@chelsio$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=faisal.latif@intel$(echo .)com \
--cc=fbl@redhat$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=hal.rosenstock@gmail$(echo .)com \
--cc=jitendra.kalsaria@qlogic$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=linux-driver@qlogic$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roland@kernel$(echo .)org \
--cc=sean.hefty@intel$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=sony.chacko@qlogic$(echo .)com \
--cc=therbert@google$(echo .)com \
--cc=ursula.braun@de$(echo .)ibm.com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox