From: Stephen Hemminger <shemminger@vyatta•com>
To: Ben Hutchings <bhutchings@solarflare•com>
Cc: bridge@lists•linux-foundation.org, ursula.braun@de•ibm.com,
john.r.fastabend@intel•com, edumazet@google•com,
sean.hefty@intel•com, therbert@google•com, roland@kernel•org,
linux-s390@vger•kernel.org, linux-rdma@vger•kernel.org,
fubar@us•ibm.com, fbl@redhat•com, hal.rosenstock@gmail•com,
Jiri Pirko <jiri@resnulli•us>,
faisal.latif@intel•com, linux-driver@qlogic•com,
blaschka@linux•vnet.ibm.com, sony.chacko@qlogic•com,
gregory.v.rose@intel•com, xiyou.wangcong@gmail•com,
jitendra.kalsaria@qlogic•com, divy@chelsio•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kaber@trash•net, joe@perches•com, linux390@de•ibm.com,
davem@davemloft•net
Subject: Re: [patch net-next v2 01/15] net: introduce upper device lists
Date: Tue, 14 Aug 2012 16:00:55 -0700 [thread overview]
Message-ID: <20120814160055.1e948456@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1344983624.2690.77.camel@bwh-desktop.uk.solarflarecom.com>
On Tue, 14 Aug 2012 23:33:44 +0100
Ben Hutchings <bhutchings@solarflare•com> wrote:
> On Tue, 2012-08-14 at 17:05 +0200, Jiri Pirko wrote:
> > This lists are supposed to serve for storing pointers to all upper devices.
> > Eventually it will replace dev->master pointer which is used for
> > bonding, bridge, team but it cannot be used for vlan, macvlan where
> > there might be multiple upper present. In case the upper link is
> > replacement for dev->master, it is marked with "master" flag.
>
> Something I found interesting is that the dev->master pointer and now
> netdev_master_upper_dev_get{,_rcu}() are hardly used by the stackled
> drivers that set the master. They also have to set an rx_handler on the
> lower device (which is itself mutually exclusive) which gets its own
> context pointer (rx_handler_data).
>
> Instead, the master pointer is mostly used by device drivers to find out
> about a bridge or bonding device above *their* devices. And that seems
> to work only for those specific device drivers, not e.g. openvswitch or
> team. I wonder if we could find a better way to encapsulate the things
> they want do do, in a later step (not holding up this change!).
The concept is master is very useful to user level config things like
Vyatta for seeing parent/child relationship. Since is in ABI now, it
must stay.
next prev parent reply other threads:[~2012-08-14 23:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 15:05 [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 01/15] net: introduce upper device lists Jiri Pirko
2012-08-14 22:33 ` Ben Hutchings
2012-08-14 23:00 ` Stephen Hemminger [this message]
2012-08-15 7:46 ` Jiri Pirko
2012-08-15 22:15 ` David Miller
[not found] ` <20120815.151549.1835466517645273818.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-08-16 5:48 ` Jiri Pirko
2012-08-15 22:12 ` David Miller
2012-08-14 15:05 ` [patch net-next v2 02/15] macvlan: add link to upper device Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 03/15] vlan: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 04/15] rtnetlink: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 05/15] team: remove usage of netdev_set_master() Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 06/15] bridge: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 07/15] netpoll: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 08/15] cxgb3: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock Jiri Pirko
[not found] ` <1344956748-2099-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2012-08-14 15:05 ` [patch net-next v2 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep() Jiri Pirko
2012-08-14 20:19 ` [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master Andy Gospodarek
2012-08-14 20:32 ` Ben Hutchings
2012-08-15 7:30 ` Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 12/15] nes: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 13/15] bonding: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master() Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 15/15] net: kill dev->master Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814160055.1e948456@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=blaschka@linux$(echo .)vnet.ibm.com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=divy@chelsio$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=faisal.latif@intel$(echo .)com \
--cc=fbl@redhat$(echo .)com \
--cc=fubar@us$(echo .)ibm.com \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=hal.rosenstock@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=jitendra.kalsaria@qlogic$(echo .)com \
--cc=joe@perches$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=linux-driver@qlogic$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux390@de$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roland@kernel$(echo .)org \
--cc=sean.hefty@intel$(echo .)com \
--cc=sony.chacko@qlogic$(echo .)com \
--cc=therbert@google$(echo .)com \
--cc=ursula.braun@de$(echo .)ibm.com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox