Subject: Re: [PATCH v2] netfilter: take care of timewait sockets

From: Florian Westphal <[email-masked]>
Date: Mon, 3 Sep 2012 09:47:18 +0200

Eric Dumazet <[email-masked]> wrote:
> Sami Farin reported crashes in xt_LOG because it assumes skb->sk is a
> full blown socket.
> 
> But with TCP early demux, we can have skb->sk pointing to a timewait
> socket.
> 
> Same fix is needed in netfnetlink_log

Looks good, but IMHO it is very un-intuitive that
skb->sk might be a pointer to an object that is not struct sock (or
a compatible object).