From: Stephen Hemminger <shemminger@vyatta•com>
To: Naresh Kumar Inna <naresh@chelsio•com>
Cc: "JBottomley@parallels•com" <JBottomley@parallels•com>,
"linux-scsi@vger•kernel.org" <linux-scsi@vger•kernel.org>,
Dimitrios Michailidis <dm@chelsio•com>,
Casey Leedom <leedom@chelsio•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Chethan Seshadri <chethan@chelsio•com>
Subject: Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).
Date: Wed, 5 Sep 2012 15:59:56 -0700 [thread overview]
Message-ID: <20120905155956.561b172d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <50478F52.208@chelsio.com>
On Wed, 5 Sep 2012 23:13:46 +0530
Naresh Kumar Inna <naresh@chelsio•com> wrote:
> On 9/5/2012 9:59 PM, Stephen Hemminger wrote:
> > On Wed, 5 Sep 2012 18:03:55 +0530
> > Naresh Kumar Inna <naresh@chelsio•com> wrote:
> >
> >> This patch contains code for driver initialization, driver resource
> >> allocation and the Work Request module functionality. Driver initialization
> >> includes module entry/exit points, registration with PCI, FC transport and
> >> SCSI mid layer subsystems. The Work Request module provides services for
> >> allocation of DMA queues, posting Work Requests on them and processing
> >> completions.
> >>
> >> Signed-off-by: Naresh Kumar Inna <naresh@chelsio•com>
> >
> > Although the comments say you are using proc fs, there is no
> > code here related to that.
>
> I will remove that comment.
>
> >
> > Any use of debugfs must be conditional the DEBUG_FS kernel configuration
> > parameter. Your code probably will break if DEBUG_FS is not
> > enabled. For a possible alternative see how a sub-config parameter
> > was added in sky2 driver.
> >
>
> It appears that debugfs_create_dir() returns an error if DEBUG_FS is not
> enabled. Considering the driver handles this error and continues
> initialization, do you still think I should guard this code within DEBUG_FS?
>
> Thanks.
That works, just make sure and test it.
next prev parent reply other threads:[~2012-09-05 22:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 12:33 [V2 PATCH 0/9] csiostor: Chelsio FCoE offload driver submission Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 1/9] csiostor: Chelsio FCoE offload driver submission (sources part 1) Naresh Kumar Inna
2012-09-05 16:23 ` Stephen Hemminger
2012-09-05 17:18 ` Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2) Naresh Kumar Inna
2012-09-05 16:29 ` Stephen Hemminger
2012-09-05 17:43 ` Naresh Kumar Inna
2012-09-05 22:59 ` Stephen Hemminger [this message]
2012-09-05 12:33 ` [V2 PATCH 3/9] csiostor: Chelsio FCoE offload driver submission (sources part 3) Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 4/9] csiostor: Chelsio FCoE offload driver submission (sources part 4) Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 5/9] csiostor: Chelsio FCoE offload driver submission (sources part 5) Naresh Kumar Inna
2012-09-05 12:33 ` [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1) Naresh Kumar Inna
2012-09-05 16:31 ` Stephen Hemminger
2012-09-05 17:26 ` Naresh Kumar Inna
2012-09-05 23:07 ` Ben Hutchings
2012-09-05 16:33 ` Stephen Hemminger
2012-09-05 17:44 ` Naresh Kumar Inna
2012-09-05 12:34 ` [V2 PATCH 7/9] csiostor: Chelsio FCoE offload driver submission (headers part 2) Naresh Kumar Inna
2012-09-05 12:34 ` [V2 PATCH 8/9] cxgb4: Chelsio FCoE offload driver submission (cxgb4 common header updates) Naresh Kumar Inna
2012-09-05 12:34 ` [V2 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes) Naresh Kumar Inna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905155956.561b172d@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=JBottomley@parallels$(echo .)com \
--cc=chethan@chelsio$(echo .)com \
--cc=dm@chelsio$(echo .)com \
--cc=leedom@chelsio$(echo .)com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=naresh@chelsio$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox