Subject: Re: [PATCH 08/11] crypto: pass crypto_user module to netlink_dump_start

From: Steffen Klassert <[email-masked]>
Date: Wed, 26 Sep 2012 07:49:45 +0200

On Wed, Sep 26, 2012 at 12:52:17PM +0800, Gao feng wrote:
> use proper netlink_dump_control.done and .module to avoid panic.
> 
> Signed-off-by: Gao feng <[email-masked]>
> Cc: Herbert Xu <[email-masked]>
> ---
>  crypto/crypto_user.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c
> index ba2c611..b5cb32b 100644
> --- a/crypto/crypto_user.c
> +++ b/crypto/crypto_user.c
> @@ -249,6 +249,7 @@ out_err:
>  
>  static int crypto_dump_report_done(struct netlink_callback *cb)
>  {
> +	netlink_dump_done(cb);
>  	return 0;

It's probaply better to return the return value of netlink_dump_done()
instead. Right now, netlink_dump_done() returns 0 in any case,
but this might change over time.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html