From: Stephen Hemminger <shemminger@vyatta•com>
To: Graham Gower <graham.gower@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.
Date: Mon, 8 Oct 2012 09:16:08 -0700 [thread overview]
Message-ID: <20121008091608.0b03befa@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <50711961.1010101@gmail.com>
On Sun, 07 Oct 2012 16:25:45 +1030
Graham Gower <graham.gower@gmail•com> wrote:
> Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
> packets on a system with >4gb ram unless a 32bit DMA mask is used.
>
> This issue has been around for years and a fix was sent 3.5 years ago, but
> there was some debate as to whether it should instead be fixed as a PCI quirk.
> http://www.spinics.net/lists/netdev/msg88670.html
>
> However, 18 months later a similar workaround was introduced for another
> chipset exhibiting the same problem.
> http://www.spinics.net/lists/netdev/msg142287.html
>
> Signed-off-by: Graham Gower <graham.gower@gmail•com>
>
> --- skge.c.bak 2012-10-07 13:00:56.000000000 +1030
> +++ skge.c 2012-10-07 13:26:03.000000000 +1030
> @@ -4143,6 +4143,13 @@
> DMI_MATCH(DMI_BOARD_NAME, "nForce"),
> },
> },
> + {
> + .ident = "ASUS P5NSLI",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> + DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
> + },
> + },
> {}
> };
>
This fix is fine, but like Jan said it needs to be based at the
right place in the filesystem tree for inclusion.
I wonder if it would be a good idea to add a way to automatically
check for this quirk using the debug registers on the chip which allow
peeking. Using the test registers B3_RAM_DATA_LO/B3_RAM_DATA_HI.
The problem is that might introduce worse problems if it causes
DMA access to non-existent memory and trying to recover from the fault.
prev parent reply other threads:[~2012-10-08 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 5:55 skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Graham Gower
2012-10-07 9:32 ` Jan Ceuleers
2012-10-08 5:33 ` Graham Gower
2012-10-08 5:33 ` [PATCH v2] " Graham Gower
2012-10-08 5:36 ` David Miller
2012-10-08 5:54 ` [PATCH v3] " Graham Gower
2012-10-08 6:11 ` David Miller
2012-10-08 6:15 ` Graham Gower
2012-10-08 6:21 ` David Miller
2012-10-08 16:16 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008091608.0b03befa@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=graham.gower@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox