Subject: Re: [PATCH 1/1] [PATCH net-next] net:dev: remove double indentical assignment in dev_change_net_namespace().

From: Serge Hallyn <[email-masked]>
Date: Fri, 19 Oct 2012 19:07:56 -0500

Quoting Rami Rosen ([email-masked]):
> This patch removes double assignment of err to -EINVAL in dev_change_net_namespace().
> 
> Signed-off-by: Rami Rosen <[email-masked]>

Yup, sure is a duplicate assignment...

Acked-by: Serge E. Hallyn <[email-masked]>

> ---
>  net/core/dev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 09cb3f6..b4978e2 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -6264,7 +6264,6 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
>  		goto out;
>  
>  	/* Ensure the device has been registrered */
> -	err = -EINVAL;
>  	if (dev->reg_state != NETREG_REGISTERED)
>  		goto out;
>  
> -- 
> 1.7.11.4
>