From: Stephen Hemminger <shemminger@vyatta•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Pavel Emelyanov <xemul@parallels•com>,
Linux Netdev List <netdev@vger•kernel.org>
Subject: Re: [PATCH 5/5] ss: Show inet and unix sockets' shutdown state
Date: Thu, 25 Oct 2012 10:09:22 -0700 [thread overview]
Message-ID: <20121025100922.12ed2061@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1351184010.6537.158.camel@edumazet-glaptop>
On Thu, 25 Oct 2012 18:53:30 +0200
Eric Dumazet <eric.dumazet@gmail•com> wrote:
> On Thu, 2012-10-25 at 08:52 -0700, Stephen Hemminger wrote:
> > On Thu, 25 Oct 2012 17:26:44 +0400
> > Pavel Emelyanov <xemul@parallels•com> wrote:
> >
> > > To see this we need kernel >=3.7 with _SHUTDOWN nlarrts in diag messages.
> > > The output will look like arrows at the end of each line, like this:
> > >
> > > ESTAB 0 0 127.0.0.1:41705 127.0.0.1:12345 ino:143321 sk:ffff88003a8cea00 -->
> > > ESTAB 0 0 127.0.0.1:46925 127.0.0.1:12346 ino:143322 sk:ffff88003a8ce4c0 <--
> > > ESTAB 0 0 127.0.0.1:51678 127.0.0.1:12347 ino:143323 sk:ffff88003a8cdf80 ---
> > > ESTAB 0 0 127.0.0.1:46911 127.0.0.1:12348 ino:143324 sk:ffff88003b7f05c0 <->
> > >
> > > for SHUT_RD, SHUT_WR, SHUT_RDWR and non-shutdown sockets respectively.
> > >
> > > Signed-off-by: Pavel Emelyanov <xemul@parallels•com>
> > >
> > > ---
> > > include/linux/inet_diag.h | 3 ++-
> > > include/linux/unix_diag.h | 1 +
> > > misc/ss.c | 26 ++++++++++++++++++++------
> > > 3 files changed, 23 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h
> > > index 8c469af..bbde90f 100644
> > > --- a/include/linux/inet_diag.h
> > > +++ b/include/linux/inet_diag.h
> > > @@ -109,9 +109,10 @@ enum {
> > > INET_DIAG_TOS,
> > > INET_DIAG_TCLASS,
> > > INET_DIAG_SKMEMINFO,
> > > + INET_DIAG_SHUTDOWN,
> > > };
> >
> > Since this requires 3.8 or later kernel, please resubmit this
> > patch during that merge window.
> > --
>
> I am wondering what possibly could happen if applying this before ?
>
> iproute2 should be non dependent on kernel version, we make sure to not
> add regressions.
>
>
>
I don't want the stashed kernel headers to get out of date with kernel exported ones.
People who want to test early features are free to build their own pre-release versions.
next prev parent reply other threads:[~2012-10-25 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 13:16 [PATCH iproute2 0/5] Teach ss to show sockets' shutdown state Pavel Emelyanov
2012-10-25 13:18 ` [PATCH 1/5] ss: Rename some tcp- names into inet- Pavel Emelyanov
2012-10-25 13:21 ` [PATCH 2/5] ss: Split inet_show_netlink into parts Pavel Emelyanov
2012-10-25 13:23 ` [PATCH 3/5] ss: Support sock-diag Pavel Emelyanov
2012-10-25 13:24 ` [PATCH 4/5] ss: Get udp sockets info via sock-diag Pavel Emelyanov
2012-10-27 0:51 ` Stephen Hemminger
2012-10-25 13:26 ` [PATCH 5/5] ss: Show inet and unix sockets' shutdown state Pavel Emelyanov
2012-10-25 15:52 ` Stephen Hemminger
2012-10-25 16:53 ` Eric Dumazet
2012-10-25 17:09 ` Stephen Hemminger [this message]
2012-10-25 18:00 ` Eric Dumazet
2012-10-25 23:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025100922.12ed2061@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xemul@parallels$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox