public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Richard Cochran <richardcochran@gmail•com>
To: Timur Tabi <timur@freescale•com>
Cc: Paul Gortmaker <paul.gortmaker@windriver•com>,
	"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	Wei Yang <Wei.Yang@windriver•com>,
	Manoil Claudiu-B08782 <B08782@freescale•com>
Subject: Re: [PATCH] gianfar_ptp: use iomem, not ioports resource tree in probe
Date: Fri, 26 Oct 2012 12:32:44 +0200	[thread overview]
Message-ID: <20121026103243.GA3092@netboy.at.omicron.at> (raw)
In-Reply-To: <50899E6C.8040403@freescale.com>

On Thu, Oct 25, 2012 at 03:17:48PM -0500, Timur Tabi wrote:
> 
> I'm sorry for what I said.  It was inappropriate.  I deal with crappy code
> from co-workers on a daily basis, and sometimes I forgot that just because
> something is done differently than I would have done it, that doesn't mean
> it's wrong.

Thanks for that apology. Now my wounded pride has recovered :)

> I actually did that research and saw Grant's comments.  I asked him about
> it on IRC, and although I understand his reasoning, I'm not sure I agree
> with all of it.  In particular, I think
> platform_get_resource/request_resource/ioremap is less elegant than just
> calling of_iomap.

No comment from me, since I always seem to lose at the DT game.

Thanks,
Richard

next prev parent reply	other threads:[~2012-10-26 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 15:21 [PATCH] gianfar_ptp: use iomem, not ioports resource tree in probe Paul Gortmaker
2012-10-24 17:59 ` Tabi Timur-B04825
2012-10-24 19:09   ` Paul Gortmaker
2012-10-24 19:12     ` Timur Tabi
2012-10-24 19:42       ` Richard Cochran
2012-10-24 20:11         ` Timur Tabi
2012-10-24 20:50           ` Richard Cochran
2012-10-25 11:41       ` wyang1
2012-10-25 20:08       ` Richard Cochran
2012-10-25 20:17         ` Timur Tabi
2012-10-26 10:32           ` Richard Cochran [this message]
2012-10-25  3:19 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026103243.GA3092@netboy.at.omicron.at \
    --to=richardcochran@gmail$(echo .)com \
    --cc=B08782@freescale$(echo .)com \
    --cc=Wei.Yang@windriver$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=paul.gortmaker@windriver$(echo .)com \
    --cc=timur@freescale$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox