Subject: Re: [PATCH 1/1] net: fix compile warning in af_unix.c

From: Stephen Hemminger <[email-masked]>
Date: Tue, 30 Oct 2012 07:00:40 -0700

On Tue, 30 Oct 2012 15:16:36 +0800
Jing Wang <[email-masked]> wrote:

> This patch fix some compile warning as follows:
> net/unix/af_unix.c: In function 'unix_bind':
> net/unix/af_unix.c:895: warning: 'path.dentry' may be used uninitialized in this function
> net/unix/af_unix.c:895: warning: 'path.mnt' may be used uninitialized in this function
> 
> Signed-off-by: Jing Wang <[email-masked]>
> ---
>  net/unix/af_unix.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index 5b5c876..9f710ac 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -895,6 +895,8 @@ static int unix_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
>  		struct path path;
>  		umode_t mode = S_IFSOCK |
>  		       (SOCK_INODE(sock)->i_mode & ~current_umask());
> +		path.mnt = NULL;
> +		path.dentry = NULL;
>  		err = unix_mknod(sun_path, mode, &path);
>  		if (err) {
>  			if (err == -EEXIST)

I appreciate the effort to silence warnings. But this warning is a false
positive that only occurs on some versions of Gcc. With gcc 4.7 the
warning does not occur.

The general consensus has been NOT to do initializations or other changes
if the problem is due to Gcc bug.