From: Richard Cochran <richardcochran@gmail•com>
To: Bob Liu <lliubbo@gmail•com>
Cc: netdev@vger•kernel.org, Miroslav Lichvar <mlichvar@redhat•com>,
John Ronciak <john.ronciak@intel•com>,
John Stultz <john.stultz@linaro•org>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
device-drivers-devel@blackfin•uclinux.org,
Jacob Keller <jacob.e.keller@intel•com>,
uclinux-dist-devel@blackfin•uclinux.org,
Patrick Ohly <patrick.ohly@intel•com>,
David Miller <davem@davemloft•net>
Subject: Re: [uclinux-dist-devel] [PATCH RFC net-next 2/4] bfin_mac: replace sys time stamps with raw ones instead.
Date: Wed, 31 Oct 2012 08:57:43 +0100 [thread overview]
Message-ID: <20121031075743.GA2327@netboy.at.omicron.at> (raw)
In-Reply-To: <CAA_GA1f6BuaY+xtMjGrvaaAoP=Z0=o3NZEwjt6F-5zYho0L7OQ@mail.gmail.com>
On Wed, Oct 31, 2012 at 02:47:21PM +0800, Bob Liu wrote:
> > @@ -861,15 +854,9 @@ static void bfin_tx_hwtstamp(struct net_device *netdev, struct sk_buff *skb)
> > regval = bfin_read_EMAC_PTP_TXSNAPLO();
> > regval |= (u64)bfin_read_EMAC_PTP_TXSNAPHI() << 32;
> > memset(&shhwtstamps, 0, sizeof(shhwtstamps));
> > - ns = timecounter_cyc2time(&lp->clock,
> > - regval);
> > - timecompare_update(&lp->compare, ns);
> > + ns = regval >> lp->shift;
>
> Why not set ns = regval << lp->shift?
> I think it's conflicted with patch [3/4]
Yes, you are right. I will fix this in V2.
> > @@ -892,51 +879,25 @@ static void bfin_rx_hwtstamp(struct net_device *netdev, struct sk_buff *skb)
> >
> > regval = bfin_read_EMAC_PTP_RXSNAPLO();
> > regval |= (u64)bfin_read_EMAC_PTP_RXSNAPHI() << 32;
> > - ns = timecounter_cyc2time(&lp->clock, regval);
> > - timecompare_update(&lp->compare, ns);
> > + ns = regval >> lp->shift;
>
> So is here.
Thanks for the careful review,
Richard
next prev parent reply other threads:[~2012-10-31 7:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 17:20 [PATCH RFC net-next 0/4] Convert blackfin to phc and remove timecompare Richard Cochran
2012-09-28 17:20 ` [PATCH RFC net-next 1/4] bfin_mac: only advertise hardware time stamped when enabled Richard Cochran
2012-09-28 17:20 ` [PATCH RFC net-next 2/4] bfin_mac: replace sys time stamps with raw ones instead Richard Cochran
2012-10-30 9:17 ` [uclinux-dist-devel] " Bob Liu
2012-10-30 13:41 ` Richard Cochran
2012-10-31 6:29 ` Bob Liu
2012-10-31 6:36 ` Bob Liu
2012-10-31 8:21 ` Richard Cochran
2012-10-31 8:36 ` Richard Cochran
2012-10-31 9:00 ` Bob Liu
2012-10-31 12:46 ` Richard Cochran
2012-11-01 2:08 ` Bob Liu
2012-11-01 8:41 ` Richard Cochran
2012-11-01 8:54 ` Bob Liu
2012-11-01 9:35 ` Richard Cochran
[not found] ` <20121101093540.GB5949-TJb37gCd1q6chkuNt9O67llkmcu1nq/N@public.gmane.org>
2012-11-01 9:39 ` Bob Liu
2012-11-01 9:42 ` [uclinux-dist-devel] " Richard Cochran
2012-10-31 6:47 ` Bob Liu
2012-10-31 7:57 ` Richard Cochran [this message]
2012-09-28 17:20 ` [PATCH RFC net-next 3/4] bfin_mac: offer a PTP Hardware Clock Richard Cochran
2012-09-28 17:20 ` [PATCH RFC net-next 4/4] time: remove the timecompare code Richard Cochran
2012-09-28 17:44 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031075743.GA2327@netboy.at.omicron.at \
--to=richardcochran@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=device-drivers-devel@blackfin$(echo .)uclinux.org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=john.stultz@linaro$(echo .)org \
--cc=lliubbo@gmail$(echo .)com \
--cc=mlichvar@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=patrick.ohly@intel$(echo .)com \
--cc=uclinux-dist-devel@blackfin$(echo .)uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox