Subject: Re: [net-next 04/11] ixgbevf: Add flag to indicate when rx is in net poll

From: Greg Rose <[email-masked]>
Date: Tue, 13 Nov 2012 11:25:09 -0800

On Tue, 13 Nov 2012 14:20:05 -0500
David Miller <[email-masked]> wrote:

> From: Jeff Kirsher <[email-masked]>
> Date: Tue, 13 Nov 2012 06:03:18 -0800
> 
> > From: Greg Rose <[email-masked]>
> > 
> > napi_gro_receive shouldn't be called from netpoll context.  Doing
> > so was causing kernel panics when jumbo frames larger than 2K were
> > set. Add a flag to check if the Rx ring processing is occurring
> > from interrupt context or from netpoll context and call netif_rx()
> > if in the polling context.
> > 
> > Signed-off-by: Greg Rose <[email-masked]>
> > Tested-by: Sibai Li <[email-masked]>
> > Signed-off-by: Jeff Kirsher <[email-masked]>
> 
> This is not a scalable solution.
> 
> It is not prudent to have every single driver do a check like
> this.  If using GRO receive from netpoll causes problems,
> then it's a generic issue rather than a driver specific one.

OK, let me look into this a bit more then.

Thanks,

- Greg