From: Stephen Hemminger <shemminger@vyatta•com>
To: Cong Wang <amwang@redhat•com>
Cc: netdev@vger•kernel.org, bridge@lists•linux-foundation.org,
Herbert Xu <herbert@gondor•hengli.com.au>,
"David S. Miller" <davem@davemloft•net>,
Thomas Graf <tgraf@suug•ch>,
Jesper Dangaard Brouer <brouer@redhat•com>
Subject: Re: [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA
Date: Fri, 30 Nov 2012 07:52:54 -0800 [thread overview]
Message-ID: <20121130075254.14aac5ce@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1354269514-1863-1-git-send-email-amwang@redhat.com>
On Fri, 30 Nov 2012 17:58:32 +0800
Cong Wang <amwang@redhat•com> wrote:
> port_no will be used to get ifindex of a port in user-space,
> export it togather with port_id.
>
> Cc: Herbert Xu <herbert@gondor•apana.org.au>
> Cc: Stephen Hemminger <shemminger@vyatta•com>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: Thomas Graf <tgraf@suug•ch>
> Cc: Jesper Dangaard Brouer <brouer@redhat•com>
> Signed-off-by: Cong Wang <amwang@redhat•com>
> Acked-by: Thomas Graf <tgraf@suug•ch>
> Signed-off-by: Cong Wang <amwang@redhat•com>
> ---
> include/uapi/linux/if_link.h | 2 ++
> net/bridge/br_netlink.c | 8 +++++++-
> 2 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index bb58aeb..9cd91a9 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -218,6 +218,8 @@ enum {
> IFLA_BRPORT_MODE, /* mode (hairpin) */
> IFLA_BRPORT_GUARD, /* bpdu guard */
> IFLA_BRPORT_PROTECT, /* root port protection */
> + IFLA_BRPORT_NO, /* port no */
> + IFLA_BRPORT_ID, /* port id */
> __IFLA_BRPORT_MAX
> };
> #define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1)
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 65429b9..7b7414e 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -28,6 +28,8 @@ static inline size_t br_port_info_size(void)
> + nla_total_size(1) /* IFLA_BRPORT_MODE */
> + nla_total_size(1) /* IFLA_BRPORT_GUARD */
> + nla_total_size(1) /* IFLA_BRPORT_PROTECT */
> + + nla_total_size(2) /* IFLA_BRPORT_NO */
> + + nla_total_size(2) /* IFLA_BRPORT_ID */
> + 0;
> }
>
> @@ -53,7 +55,9 @@ static int br_port_fill_attrs(struct sk_buff *skb,
> nla_put_u32(skb, IFLA_BRPORT_COST, p->path_cost) ||
> nla_put_u8(skb, IFLA_BRPORT_MODE, mode) ||
> nla_put_u8(skb, IFLA_BRPORT_GUARD, !!(p->flags & BR_BPDU_GUARD)) ||
> - nla_put_u8(skb, IFLA_BRPORT_PROTECT, !!(p->flags & BR_ROOT_BLOCK)))
> + nla_put_u8(skb, IFLA_BRPORT_PROTECT, !!(p->flags & BR_ROOT_BLOCK)) ||
> + nla_put_u16(skb, IFLA_BRPORT_NO, p->port_no) ||
> + nla_put_u16(skb, IFLA_BRPORT_ID, p->port_id))
> return -EMSGSIZE;
>
> return 0;
> @@ -168,6 +172,8 @@ static const struct nla_policy ifla_brport_policy[IFLA_BRPORT_MAX + 1] = {
> [IFLA_BRPORT_MODE] = { .type = NLA_U8 },
> [IFLA_BRPORT_GUARD] = { .type = NLA_U8 },
> [IFLA_BRPORT_PROTECT] = { .type = NLA_U8 },
> + [IFLA_BRPORT_NO] = { .type = NLA_U16 },
> + [IFLA_BRPORT_ID] = { .type = NLA_U16 },
> };
>
> /* Change the state of the port and notify spanning tree */
I don't think these are necessary. The device is already available and the relationship
can be determined from other messages. This is what RSTP daemon does.
next prev parent reply other threads:[~2012-11-30 15:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 9:58 [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA Cong Wang
2012-11-30 9:58 ` [PATCH net-next v1 2/2] bridge: export multicast database via netlink Cong Wang
2012-11-30 11:26 ` Thomas Graf
2012-11-30 15:00 ` Cong Wang
2012-11-30 15:27 ` Thomas Graf
2012-12-01 3:56 ` Cong Wang
2012-11-30 9:58 ` [PATCH iproute2 v1] Add mdb command to bridge Cong Wang
2012-11-30 10:54 ` Thomas Graf
2012-11-30 14:50 ` Cong Wang
2012-11-30 10:18 ` [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA Thomas Graf
2012-11-30 14:51 ` Cong Wang
2012-11-30 15:52 ` Stephen Hemminger [this message]
2012-12-01 3:53 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130075254.14aac5ce@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta$(echo .)com \
--cc=amwang@redhat$(echo .)com \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=brouer@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)hengli.com.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox