Subject: Re: sky2: Correct mistakenly switched read/write sequence

From: Stephen Hemminger <[email-masked]>
Date: Sat, 1 Dec 2012 10:36:53 -0800

On Sat, 1 Dec 2012 13:42:39 +0100
Lino Sanfilippo <[email-masked]> wrote:

> In sky2_all_down() the order of the read()/write() access to B0_IMSK seems to
> be mistakenly switched. The original intention was obviously to avoid PCI write
> posting.
> This patch fixes the order.
> 
> Signed-off-by: Lino Sanfilippo <[email-masked]>

You are both right. David is correct in that the original code here
was quite different and was doing save/restore of irq mask.
That changed as driver evolved to only bring up IRQ if device was
brought up. At which point the read of irq mask was a left over call.

Lino is correct, it makes sense to do read after write to ensure PCI posting.
So I agree with the patch, but would like the commit message changed
slightly.