From: Lino Sanfilippo <LinoSanfilippo@gmx•de>
To: shemminger@vyatta•com, mlindner@marvell•com
Cc: davem@davemloft•net, netdev@vger•kernel.org
Subject: sky2: Correct mistakenly switched read/write sequence
Date: Sat, 1 Dec 2012 13:42:39 +0100 [thread overview]
Message-ID: <20121201124239.GB3914@neptun> (raw)
In sky2_all_down() the order of the read()/write() access to B0_IMSK seems to
be mistakenly switched. The original intention was obviously to avoid PCI write
posting.
This patch fixes the order.
Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx•de>
---
drivers/net/ethernet/marvell/sky2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 78946fe..b20d2fd 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -3481,8 +3481,8 @@ static void sky2_all_down(struct sky2_hw *hw)
int i;
if (hw->flags & SKY2_HW_IRQ_SETUP) {
- sky2_read32(hw, B0_IMSK);
sky2_write32(hw, B0_IMSK, 0);
+ sky2_read32(hw, B0_IMSK);
synchronize_irq(hw->pdev->irq);
napi_disable(&hw->napi);
--
1.7.9.5
next reply other threads:[~2012-12-01 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 12:42 Lino Sanfilippo [this message]
2012-12-01 17:27 ` sky2: Correct mistakenly switched read/write sequence David Miller
2012-12-01 20:06 ` Lino Sanfilippo
2012-12-01 18:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121201124239.GB3914@neptun \
--to=linosanfilippo@gmx$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=mlindner@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox