From: "Michael S. Tsirkin" <mst@redhat•com>
To: Jason Wang <jasowang@redhat•com>
Cc: rusty@rustcorp•com.au, krkumar2@in•ibm.com,
virtualization@lists•linux-foundation.org,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kvm@vger•kernel.org, bhutchings@solarflare•com,
jwhan@filewood•snu.ac.kr, shiyer@redhat•com
Subject: Re: [net-next rfc v7 2/3] virtio_net: multiqueue support
Date: Mon, 3 Dec 2012 12:14:36 +0200 [thread overview]
Message-ID: <20121203101436.GB23009@redhat.com> (raw)
In-Reply-To: <1354011360-39479-3-git-send-email-jasowang@redhat.com>
On Tue, Nov 27, 2012 at 06:15:59PM +0800, Jason Wang wrote:
> - if (!try_fill_recv(&vi->rq, GFP_KERNEL))
> - schedule_delayed_work(&vi->rq.refill, 0);
> + for (i = 0; i < vi->max_queue_pairs; i++)
> + if (!try_fill_recv(&vi->rq[i], GFP_KERNEL))
> + schedule_delayed_work(&vi->rq[i].refill, 0);
>
> mutex_lock(&vi->config_lock);
> vi->config_enable = true;
> mutex_unlock(&vi->config_lock);
>
> + BUG_ON(virtnet_set_queues(vi));
> +
> return 0;
> }
> #endif
Also crashing on device nack of command is also not nice.
In this case it seems we can just switch to
single-queue mode which should always be safe.
next prev parent reply other threads:[~2012-12-03 10:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 10:15 [net-next rfc v7 0/3] Multiqueue virtio-net Jason Wang
2012-11-27 10:15 ` [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info Jason Wang
2012-12-03 1:55 ` Rusty Russell
2012-12-03 5:15 ` Jason Wang
2012-12-03 11:18 ` Michael S. Tsirkin
2012-12-04 9:22 ` Jason Wang
2012-12-04 3:43 ` Rusty Russell
2012-12-04 9:23 ` Jason Wang
2012-11-27 10:15 ` [net-next rfc v7 2/3] virtio_net: multiqueue support Jason Wang
2012-12-02 16:06 ` Michael S. Tsirkin
2012-12-03 5:47 ` Jason Wang
2012-12-03 2:04 ` Rusty Russell
2012-12-03 6:05 ` Jason Wang
2012-12-03 9:47 ` Michael S. Tsirkin
2012-12-03 10:01 ` Jason Wang
2012-12-03 11:11 ` Michael S. Tsirkin
2012-12-04 9:24 ` Jason Wang
2012-12-03 10:14 ` Michael S. Tsirkin [this message]
2012-12-03 10:30 ` Jason Wang
2012-12-03 11:00 ` Michael S. Tsirkin
2012-12-04 7:35 ` Michael S. Tsirkin
2012-12-04 9:27 ` Jason Wang
2012-11-27 10:16 ` [net-next rfc v7 3/3] virtio-net: change the number of queues through ethtool Jason Wang
2012-12-02 16:09 ` Michael S. Tsirkin
2012-12-03 6:09 ` Jason Wang
2012-12-03 11:25 ` Michael S. Tsirkin
2012-12-04 0:22 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203101436.GB23009@redhat.com \
--to=mst@redhat$(echo .)com \
--cc=bhutchings@solarflare$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jwhan@filewood$(echo .)snu.ac.kr \
--cc=krkumar2@in$(echo .)ibm.com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rusty@rustcorp$(echo .)com.au \
--cc=shiyer@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox